-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Make RawConfig
serializeable
#382
Comments
Also: My (and a lot of peoples) config struct incorporates |
@Creative-Difficulty Can you point to those other requests? Just not sure I've seen them. |
pr i opened |
@Creative-Difficulty Yup I saw that PR. I was talking about the comment you made (see below).
I just wanted to take a look at the other requests. |
I'm also curious about how your changes support the following:
|
Thats another issue, however now i can deserialize it from a string, modify some properties and serialize it back. So at the moment it's just programmatic modification, which really helps with tests. |
@Creative-Difficulty any updates on this? |
@Creative-Difficulty I don't believe either of these are requesting for the RawConfig to be made serializable. However, I'll take a look since it appears to largely be auto generated code |
I'm serializing
RawConfig
into TOML in my CLI and for my tests (and also to be able to constructRawConfig
programmatically) it is neccesary to serializeRawConfig
into a string. Some other issues have been opened about this, so I think the community is interested. This would greatly benefit many projects and I don't think it would require much work for the library. I'm currently considering opening a PR myself.@estk
The text was updated successfully, but these errors were encountered: