Skip to content

Commit 2b2473c

Browse files
authoredJul 9, 2024··
Merge pull request #18284 from thedtripp/check-tools-mod-in-verify-deps
[3.5] make: Include tools/mod when checking dependency versions
2 parents 472de10 + 35a9140 commit 2b2473c

File tree

3 files changed

+184
-40
lines changed

3 files changed

+184
-40
lines changed
 

‎test.sh

+7
Original file line numberDiff line numberDiff line change
@@ -637,7 +637,14 @@ function dump_deps_of_module() {
637637
# Checks whether dependencies are consistent across modules
638638
function dep_pass {
639639
local all_dependencies
640+
local tools_mod_dependencies
640641
all_dependencies=$(run_for_modules dump_deps_of_module | sort) || return 2
642+
# tools/mod is a special case. It is a module that is not included in the
643+
# module list from test_lib.sh. However, we need to ensure that the
644+
# dependency versions match the rest of the project. Therefore, explicitly
645+
# execute the command for tools/mod, and append its dependencies to the list.
646+
tools_mod_dependencies=$(run_for_module "tools/mod" dump_deps_of_module "./...") || return 2
647+
all_dependencies="${all_dependencies}"$'\n'"${tools_mod_dependencies}"
641648

642649
local duplicates
643650
duplicates=$(echo "${all_dependencies}" | cut -d ',' -f 1,2 | sort | uniq | cut -d ',' -f 1 | sort | uniq -d) || return 2

‎tools/mod/go.mod

+10-9
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,15 @@ require (
1010
github.com/coreos/license-bill-of-materials v0.0.0-20190913234955-13baff47494e
1111
github.com/gogo/protobuf v1.3.2
1212
github.com/gordonklaus/ineffassign v0.0.0-20200809085317-e36bfde3bb78
13-
github.com/grpc-ecosystem/grpc-gateway v1.14.6
13+
github.com/grpc-ecosystem/grpc-gateway v1.16.0
1414
github.com/gyuho/gocovmerge v0.0.0-20171205171859-50c7e6afd535
1515
github.com/hexfusion/schwag v0.0.0-20170606222847-b7d0fc9aadaa
1616
github.com/mdempsky/unconvert v0.0.0-20200228143138-95ecdbfc0b5f
1717
github.com/mgechev/revive v1.0.2
1818
github.com/mikefarah/yq/v3 v3.0.0-20201125113350-f42728eef735
1919
go.etcd.io/gofail v0.1.0
2020
go.etcd.io/protodoc v0.0.0-20180829002748-484ab544e116
21-
honnef.co/go/tools v0.0.0-20190523083050-ea95bdfd59fc
21+
honnef.co/go/tools v0.0.1-2019.2.3
2222
mvdan.cc/unparam v0.0.0-20200501210554-b37ab49443f7
2323
)
2424

@@ -46,15 +46,15 @@ require (
4646
github.com/inconshreveable/mousetrap v1.0.0 // indirect
4747
github.com/kylelemons/godebug v1.1.0 // indirect
4848
github.com/mailru/easyjson v0.7.1 // indirect
49-
github.com/mattn/go-colorable v0.1.7 // indirect
50-
github.com/mattn/go-isatty v0.0.12 // indirect
51-
github.com/mattn/go-runewidth v0.0.7 // indirect
49+
github.com/mattn/go-colorable v0.1.11 // indirect
50+
github.com/mattn/go-isatty v0.0.14 // indirect
51+
github.com/mattn/go-runewidth v0.0.9 // indirect
5252
github.com/mgechev/dots v0.0.0-20190921121421-c36f7dcfbb81 // indirect
5353
github.com/mitchellh/go-homedir v1.1.0 // indirect
5454
github.com/mitchellh/mapstructure v1.1.2 // indirect
55-
github.com/olekukonko/tablewriter v0.0.4 // indirect
55+
github.com/olekukonko/tablewriter v0.0.5 // indirect
5656
github.com/pkg/errors v0.9.1 // indirect
57-
github.com/spf13/cobra v1.0.0 // indirect
57+
github.com/spf13/cobra v1.1.3 // indirect
5858
github.com/spf13/pflag v1.0.5 // indirect
5959
github.com/trustmaster/go-aspell v0.0.0-20200701131845-c2b1f55bec8f // indirect
6060
go.mongodb.org/mongo-driver v1.3.0 // indirect
@@ -64,9 +64,10 @@ require (
6464
golang.org/x/text v0.14.0 // indirect
6565
golang.org/x/tools v0.6.0 // indirect
6666
golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1 // indirect
67-
google.golang.org/genproto v0.0.0-20201008135153-289734e2e40c // indirect
67+
google.golang.org/genproto v0.0.0-20230822172742-b8732ec3820d // indirect
68+
google.golang.org/genproto/googleapis/api v0.0.0-20230822172742-b8732ec3820d // indirect
6869
google.golang.org/protobuf v1.33.0 // indirect
6970
gopkg.in/op/go-logging.v1 v1.0.0-20160211212156-b2cb9fa56473 // indirect
70-
gopkg.in/yaml.v2 v2.3.0 // indirect
71+
gopkg.in/yaml.v2 v2.4.0 // indirect
7172
gopkg.in/yaml.v3 v3.0.1 // indirect
7273
)

0 commit comments

Comments
 (0)
Please sign in to comment.