Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

cannon: Implement bltzal in the onchain MIPS64 FPVM #13429

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

Inphi
Copy link
Contributor

@Inphi Inphi commented Dec 16, 2024

Implement the bltzal instruction for MIPS64.sol. This instruction was implemented offchain but not onchain.

Meta

Fixes #13426

@Inphi Inphi requested a review from mbaxter December 16, 2024 23:40
@Inphi Inphi requested review from a team as code owners December 16, 2024 23:40
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.37%. Comparing base (cc16851) to head (0318a97).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #13429   +/-   ##
========================================
  Coverage    47.37%   47.37%           
========================================
  Files          941      941           
  Lines        78583    78583           
  Branches       803      803           
========================================
+ Hits         37229    37232    +3     
+ Misses       38583    38573   -10     
- Partials      2771     2778    +7     
Flag Coverage Δ
cannon-go-tests-32 62.23% <ø> (ø)
cannon-go-tests-64 57.31% <ø> (+0.10%) ⬆️
contracts-bedrock-tests 92.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 11 files with indirect coverage changes

@Inphi Inphi added this pull request to the merge queue Dec 17, 2024
Merged via the queue into develop with commit 0d0f69d Dec 17, 2024
42 checks passed
@Inphi Inphi deleted the inphi/cannon-bltzal branch December 17, 2024 15:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instruction bltzal is not implemented in the Solidity code, but it is implemented in go
2 participants