-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix assets redirect #243
Comments
There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity. |
This seems like a small thing that would complete the eip to erc migration, and at the very least should be in the docs. |
Agreed! @lightclient how hard is this to do? |
There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity. |
There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity. |
This issue was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback. |
Pull Request
#242
What happened?
I make assets/erc-#/. Then I hyperlink to text in my docs. It errors with HTML Proofer since file doesn't exist.
In this commit, we fix it by changing erc-# to eip-#, even though that folder doesn't exist.
On compilation, I think assets/erc-# should automatically ln/symlink to assets/eip-# so that behavior is always intuitive.
Relevant log output
At ./_site/EIPS/eip-7524.html:252:
internally linking to ../assets/erc-7524/sec2-v2.pdf, which does not exist
At ./_site/EIPS/eip-7524.html:281:
internally linking to ../assets/erc-7524/sec1-v2.pdf, which does not exist
I get this issue from HTMLProofer when hyperlinking intuitively for the way it compiles in VSCode.
The text was updated successfully, but these errors were encountered: