Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix assets redirect #243

Closed
Divide-By-0 opened this issue Feb 7, 2024 · 6 comments
Closed

Fix assets redirect #243

Divide-By-0 opened this issue Feb 7, 2024 · 6 comments
Labels
bug Something isn't working w-stale

Comments

@Divide-By-0
Copy link
Contributor

Divide-By-0 commented Feb 7, 2024

Pull Request

#242

What happened?

I make assets/erc-#/. Then I hyperlink to text in my docs. It errors with HTML Proofer since file doesn't exist.

In this commit, we fix it by changing erc-# to eip-#, even though that folder doesn't exist.

On compilation, I think assets/erc-# should automatically ln/symlink to assets/eip-# so that behavior is always intuitive.

Relevant log output

  • At ./_site/EIPS/eip-7524.html:252:
    internally linking to ../assets/erc-7524/sec2-v2.pdf, which does not exist

  • At ./_site/EIPS/eip-7524.html:281:
    internally linking to ../assets/erc-7524/sec1-v2.pdf, which does not exist

I get this issue from HTMLProofer when hyperlinking intuitively for the way it compiles in VSCode.

@Divide-By-0 Divide-By-0 added the bug Something isn't working label Feb 7, 2024
Copy link

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@Divide-By-0
Copy link
Contributor Author

This seems like a small thing that would complete the eip to erc migration, and at the very least should be in the docs.

@SamWilsn
Copy link
Contributor

Agreed! @lightclient how hard is this to do?

Copy link

github-actions bot commented Jul 2, 2024

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added w-stale and removed w-stale labels Jul 2, 2024
@ethereum ethereum deleted a comment from Diversexchanged Jul 3, 2024
@ethereum ethereum deleted a comment from Diversexchanged Jul 3, 2024
Copy link

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

Copy link

This issue was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 17, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working w-stale
Projects
None yet
Development

No branches or pull requests

3 participants
@Divide-By-0 @SamWilsn and others