feat: add status metric to detect failed runs #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skylenet
changed the title
skylenet
pushed a commit
that referenced
this pull request
Jan 14, 2025
🤖 I have created a release *beep* *boop* --- ## [0.1.0](0.0.1...0.1.0) (2024-12-03) ### Features * add status metric to detect failed runs ([#10](#10)) ([2085ab3](2085ab3)) * **ci:** add workflows for build, pr check and deploy ([2058429](2058429)) * **ci:** add workflows for build, pr check, deploy ([413fdc2](413fdc2)) ### Bug Fixes * add first version for release-please ([#13](#13)) ([2db4530](2db4530)) * directory structure ([a378980](a378980)) * match package name with repo name ([974ed16](974ed16)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we couldn't identify if a run failed just based on the reported nodes. Because these were based on the contents of the files. If a run would fail, the file could still exist and it would report a valid ENR count.
This additional metric should make it easy to spot if a run failed.