Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Test fails if json trace is enabled #390

Closed
rmeissner opened this issue Nov 15, 2018 · 0 comments · Fixed by #438
Closed

Test fails if json trace is enabled #390

rmeissner opened this issue Nov 15, 2018 · 0 comments · Fixed by #438

Comments

@rmeissner
Copy link
Contributor

While trying to debug some tests for constantinople I run into the issue that some tests started failing when I enabled --jsontrace.

Without --jsontrace:
node ./tests/tester -s --fork='Constantinople' --test='extCodeHashDynamicArgument' --data=0 --gas=0 --value=0

TAP version 13
# GeneralStateTests
# file: extCodeHashDynamicArgument test: extCodeHashDynamicArgument
ok 1 the state roots should match

1..1
# tests 1
# pass  1

# ok

with --jsontrace

node ./tests/tester -s --fork='Constantinople' --test='extCodeHashDynamicArgument' --data=0 --gas=0 --value=0 --jsontrace

TAP version 13
# GeneralStateTests
# file: extCodeHashDynamicArgument test: extCodeHashDynamicArgument
# {"pc":0,"op":96,"gas":"0x5c7b8","gasCost":"0x3","stack":[],"depth":0,"opName":"PUSH1"}
# {"pc":2,"op":53,"gas":"0x5c7b5","gasCost":"0x3","stack":["0x0"],"depth":0,"opName":"CALLDATALOAD"}
# {"pc":3,"op":63,"gas":"0x5c7b2","gasCost":"0x190","stack":["0x1"],"depth":0,"opName":"EXTCODEHASH"}
# {"pc":4,"op":96,"gas":"0x5c622","gasCost":"0x3","stack":["0x0"],"depth":0,"opName":"PUSH1"}
# {"pc":6,"op":85,"gas":"0x5c61f","gasCost":"0x0","stack":["0x0","0x0"],"depth":0,"opName":"SSTORE"}
# {"pc":7,"op":96,"gas":"0x5b297","gasCost":"0x3","stack":[],"depth":0,"opName":"PUSH1"}
# {"pc":9,"op":53,"gas":"0x5b294","gasCost":"0x3","stack":["0x0"],"depth":0,"opName":"CALLDATALOAD"}
# {"pc":10,"op":59,"gas":"0x5b291","gasCost":"0x2bc","stack":["0x1"],"depth":0,"opName":"EXTCODESIZE"}
# {"pc":11,"op":96,"gas":"0x5afd5","gasCost":"0x3","stack":["0x0"],"depth":0,"opName":"PUSH1"}
# {"pc":13,"op":85,"gas":"0x5afd2","gasCost":"0x0","stack":["0x0","0x1"],"depth":0,"opName":"SSTORE"}
not ok 1 the state roots should match
  ---
    operator: equal
    expected: |-
      '2ceab025ea1bcf156d3b82dcd37082bbd7550c50933057550a55a7dce4c06df0'
    actual: |-
      'dfbd02fee291d961905b27a5b42838a7c946fb89514534217e6bb3344d2dad71'
    at: replenish (/Users/rimeissner/gnosis/ethereumjs-vm/node_modules/async/dist/async.js:1011:17)
  ...

1..1
# tests 1
# pass  0
# fail  1

This was done on the eip-1052 branch (commit d661bde)

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants