Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove ProviderEngine #115

Closed
holgerd77 opened this issue Apr 29, 2020 · 1 comment · Fixed by #117
Closed

Remove ProviderEngine #115

holgerd77 opened this issue Apr 29, 2020 · 1 comment · Fixed by #117

Comments

@holgerd77
Copy link
Member

holgerd77 commented Apr 29, 2020

Support for ProviderEngine implemented in provider-engine.ts is bringing in the web3-provider-engine dependency.

This draws in a myriad of unnecessary additional dependencies which are often outdated since the package is not very actively maintained and superseded by json-rpc-engine. This is problematic from a security POV (mildly speaking) and significantly diminishes the installation experience especially through various older versions of the hashing libraries (keccak, secp2561) drawn in.

I would suggest to remove this feature, it should be relatively easily possible to do this integration on the user side if needed by adopting the code from provider-engine.ts.

//cc @kumavis

@kumavis
Copy link
Member

kumavis commented Apr 30, 2020

@holgerd77 find by me 👍 , be sure to respect semver in its removal

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants