Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Repeated definition for output clock divide by 64 in function select_r_div #89

Open
hwstar opened this issue Jul 20, 2022 · 0 comments
Open

Comments

@hwstar
Copy link

hwstar commented Jul 20, 2022

In the function select_r_div, I have a question about lines 1731 through 1740. The else-if blocks are are exactly the same and are redundant. See this snippet below. Is this intentional or is it a mistake?

uint8_t Si5351::select_r_div(uint64_t *freq)
{
.
.
.
#Line 1731
else if((*freq >= SI5351_CLKOUT_MIN_FREQ * SI5351_FREQ_MULT * 2) && (*freq < SI5351_CLKOUT_MIN_FREQ * SI5351_FREQ_MULT * 4))
{
r_div = SI5351_OUTPUT_CLK_DIV_64;
*freq *= 64ULL;
}
else if((*freq >= SI5351_CLKOUT_MIN_FREQ * SI5351_FREQ_MULT * 2) && (*freq < SI5351_CLKOUT_MIN_FREQ * SI5351_FREQ_MULT * 4))
{
r_div = SI5351_OUTPUT_CLK_DIV_64;
*freq *= 64ULL;
}
.
.
.
}

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant