Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove nonexistent references from package.json #1133

Closed
wants to merge 2 commits into from

Conversation

desfero
Copy link

@desfero desfero commented Nov 2, 2020

Nonexistent reference to /lib/index.d.ts is causing some issues for typescript based projects.
main is now referencing dist/index.js
and module was removed

@ricmoo ricmoo added the on-deck This Enhancement or Bug is currently being worked on. label Nov 2, 2020
@ricmoo
Copy link
Member

ricmoo commented Nov 2, 2020

Awesome! Thanks! Too aggressive with my copy-paste I suppose.

I'm making some changes to the ESM exports right now, and will roll this into the next version later this week. :)

@desfero
Copy link
Author

desfero commented Nov 16, 2020

@ricmoo is there any estimated time we can expect the fix to be released?

ricmoo added a commit that referenced this pull request Nov 19, 2020
@ricmoo ricmoo added the bug Verified to be an issue. label Nov 19, 2020
@ricmoo
Copy link
Member

ricmoo commented Nov 19, 2020

I've fixed this in master. Once the CI has passed I'll publish it. :)

@ricmoo
Copy link
Member

ricmoo commented Nov 20, 2020

This should be fixed in 5.0.21. Try it out and let me know.

@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels Nov 20, 2020
@ricmoo
Copy link
Member

ricmoo commented Nov 23, 2020

Closing this now, but if you have any issues with the fix, please re-open.

Thanks! :)

@ricmoo ricmoo closed this Nov 23, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants