fix: for batch requests make sure all promises are complete (either fulfilled or rejected) #4118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! I’ll get to it shortly. :) |
ricmoo
added
bug
ricmoo
added a commit
that referenced
this pull request
Jun 7, 2023
Woodpile37
pushed a commit
to Woodpile37/ethers.js
that referenced
this pull request
Jan 14, 2024
Woodpile37
pushed a commit
to Woodpile37/ethers.js
that referenced
this pull request
Jan 14, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
JsonRpcApiProvider, when processing the results, if one of the results is an error, then the loop exits prematurely and all the remaining promises are neither resolved nor rejected.This PR marks error results as rejected promises, but continues processing all requests in the batch so all promises finish correctly (either fulfill or reject).