Skip to content
This repository was archived by the owner on Aug 2, 2021. It is now read-only.

Possible goroutine leak in Swarm.Start #1156

Closed
janos opened this issue Jan 23, 2019 · 0 comments · Fixed by ethereum/go-ethereum#19040
Closed

Possible goroutine leak in Swarm.Start #1156

janos opened this issue Jan 23, 2019 · 0 comments · Fixed by ethereum/go-ethereum#19040
Assignees

Comments

@janos
Copy link
Member

janos commented Jan 23, 2019

A goroutine created in Swarm.periodicallyUpdateGauges method is not terminated when Swarm.Stop is called. After a new call to Swarm.Start, another goroutine will be created with the same functionality.

This is a nonissue for production, since the Swarm is started only once. This only affects tests where Swarm is used as a service in simulations and if stop is called too many times.

Should we add more complexity or leave it as it is?

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
2 participants