Skip to content

Does not work on linux using node >= 7 #2

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
jeroenvollenbrock opened this issue Feb 2, 2018 · 6 comments
Closed

Does not work on linux using node >= 7 #2

jeroenvollenbrock opened this issue Feb 2, 2018 · 6 comments

Comments

@jeroenvollenbrock
Copy link

The module does not work in node v8.9, the timezone does not get modified.

@evanlucas
Copy link
Owner

Hi, @jeroenvollenbrock. Thanks for opening an issue. Do you have a reproducible test case that shows this? Also, what platform and exact node version are you running?

@jeroenvollenbrock
Copy link
Author

The test.js in the repository fails to run on the latest debian stretch using NodeJS 8.9.4

@jeroenvollenbrock
Copy link
Author

Hi @evanlucas, Do you happen to have any update on this issue?

@evanlucas
Copy link
Owner

I'm honestly not sure what the problem is here. I can reproduce on debian jessie as well. Isn't an issue on macOS though.

@evanlucas
Copy link
Owner

Hi, can you try v1.0.4? That should fix the issue we have been seeing. I just confirmed it works on Debian Jessie. Thanks!

@jeroenvollenbrock
Copy link
Author

Seems to work, Awesome! 😄
Feeling kinda stupid for failing to recognize the need for the additional tzset call 🙈

Given the conversation in the node issue and the discussion in the PR, i'm thinking of writing a seperate module that listens for the different platform timezone events and invoke the timezone change notification when it receives a trigger. I've already written one to use the DBus systemd api to do this for my specific use-case, but i guess a simple inotify on the timezone config files might result in a more compatible setup. It bugs me a bit that there is no currently available way to correctly handle these changes, especially with more and more electron-like and daemon-style node applications coming up.

@jeroenvollenbrock jeroenvollenbrock changed the title Does not work in node 8.9 Does not work on linux using node >= 7 Apr 14, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants