Skip to content
This repository has been archived by the owner on Jan 5, 2019. It is now read-only.

Support new call interface #184

Open
axic opened this issue Jan 26, 2018 · 4 comments
Open

Support new call interface #184

axic opened this issue Jan 26, 2018 · 4 comments

Comments

@axic
Copy link
Member

axic commented Jan 26, 2018

  • return values have been changed
  • return value isn't written to be a paramater but retrieved via returndatacopy
@axic axic mentioned this issue Mar 16, 2018
44 tasks
@lrettig
Copy link
Member

lrettig commented Mar 16, 2018

Need to add:

  • RETURNDATASIZE
  • RETURNDATACOPY

(Cf. https://github.com/ethereum/ethereumj/pull/919/files#diff-e2305a94a8fe46fe43860fc9ed6a5eacR789)

Need to update:

@lrettig
Copy link
Member

lrettig commented Mar 17, 2018

@axic: to be clear, the CREATE opcode and EEI methods have not changed--it's just that they clear the return data buffer, right? So CREATE does not need to change in evm2wasm, since this will happen at a lower level, right?

@axic
Copy link
Member Author

axic commented Mar 23, 2018

CALLSTATIC (callStatic to be added in #163)

This is actually called STATICCALL in EVM.

to be clear, the CREATE opcode and EEI methods have not changed--it's just that they clear the return data buffer, right?

Yeah actually CREATE doesn't need to be changed.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants