Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[🔧 linting]: consider replacing of the lint-space and html linter integration (require njk support) #1409

Open
ala-n opened this issue Jan 12, 2023 · 0 comments · May be fixed by #1493
Open

[🔧 linting]: consider replacing of the lint-space and html linter integration (require njk support) #1409

ala-n opened this issue Jan 12, 2023 · 0 comments · May be fixed by #1493
Assignees
@abarmina @Natalie-Smirnova
Labels
enhancement Improvements and additions to code

Comments

@ala-n
Copy link
Collaborator

ala-n commented Jan 12, 2023 •
edited
Loading

As an ESL contributor, I want stable and correct HTML linting.
Unfortunately, as for now, there is a couple of related problems:

  • lint-space behaves incorrectly for .njk files right now as well as it is not fully compatible with beautified HTML
    It is requested to investigate and consider of lint-space tool removal and replacement by other tools
  • consider HTML liner integration ([🔨 lint]: consider html-lint plugin integration #331)

Note: njk linting was disabled due to incorrect lint-space behaviour
@ala-n ala-n mentioned this issue Jan 12, 2023
Open
2 tasks
@ala-n ala-n added enhancement Improvements and additions to code and removed needs assignee labels Jan 23, 2023
@ala-n ala-n added this to the ⚡ESL 4.*.* Bugfix & support milestone Jan 23, 2023
@Natalie-Smirnova Natalie-Smirnova linked a pull request Feb 20, 2023 that will close this issue
Draft
@ala-n ala-n removed this from the ⚡ESL 4.*.* Bugfix & support milestone Aug 8, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@abarmina abarmina

@Natalie-Smirnova Natalie-Smirnova

Labels
enhancement Improvements and additions to code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(lint): install html lint to lint njk and html files, remo… exadel-inc/esl
3 participants
@ala-n @abarmina @Natalie-Smirnova