Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[🚩esl-modal]: beta release version of esl-modal module #1376

Open
6 tasks done
NastaLeo opened this issue Dec 12, 2022 · 0 comments · May be fixed by #1969
Open
6 tasks done

[🚩esl-modal]: beta release version of esl-modal module #1376

NastaLeo opened this issue Dec 12, 2022 · 0 comments · May be fixed by #1969
Assignees
Labels
feature New feature

Comments

@NastaLeo
Copy link
Collaborator

NastaLeo commented Dec 12, 2022

As ESL consumer, I want to have a modal dialog component implemented on the ESL side.

The scope of features to support:

  • ESLToggleable based implementation (to support ESLTrigger as an activator and unified interface)
  • Auto move to the body to prevent overflow hidden from taking effect on esl-modal
  • Support for the scroll lock strategies
  • Support for the separate customizable backdrop element (attention to 'native' scroll lock strategy)
  • Support for the basic focus trap
  • provide the styles to support basic modal

Out of MVP scope:

@NastaLeo NastaLeo self-assigned this Dec 12, 2022
@ala-n ala-n changed the title [🚀 esl-modal]: implement new component [🚩esl-modal]: beta version of esl-modal module Dec 15, 2022
@ala-n ala-n added the feature New feature label Jun 28, 2023
ala-n pushed a commit that referenced this issue Jul 18, 2023
@ala-n ala-n added this to the ⚡ESL: 4.10.0 Minor release milestone Jul 25, 2023
@ala-n ala-n changed the title [🚩esl-modal]: beta version of esl-modal module [🚩esl-modal]: beta release version of esl-modal module Oct 2, 2023
@NastaLeo NastaLeo linked a pull request Oct 2, 2023 that will close this issue
@ala-n ala-n removed this from the ⚡ESL: 5.1.0 Minor release milestone Feb 3, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants