Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

beer-song: update tests to canonical-data v2.0.0 #1128

Closed
cmccandless opened this issue Dec 4, 2017 · 2 comments
Closed

beer-song: update tests to canonical-data v2.0.0 #1128

cmccandless opened this issue Dec 4, 2017 · 2 comments

Comments

@cmccandless
Copy link
Contributor

Currently, the beer-song exercise does not reference the canonical data. The current tests must be checked and, if necessary, updated to match the canonical data. A comment line referencing the canonical data version must also be added (see #784 for the format of this comment).

@ajubin
Copy link

ajubin commented Jan 24, 2018

Hi, I'd like to contribute to this repo,
I've read the contributing guide, should I do a pull request directly once I fixed the issue ?

@cmccandless
Copy link
Contributor Author

@ajubin This issue already has a PR (#1165). If you would like to contribute, please see the list of exercises with the help wanted label.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants