Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add UWS_HTTP environment variable #3206

Closed
wants to merge 1 commit into from
Closed

Add UWS_HTTP environment variable #3206

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 14, 2017

By setting the UWS_HTTP environment variable to truthy one can now
experiment with uws as the low level HTTP library (as opposed to
core Node.js HTTP)

#3205

This is not very optimal but should be enough to allow experimentation

By setting the UWS_HTTP environment variable to truthy one can now
experiment with uws as the low level HTTP library (as opposed to
core Node.js HTTP)
@dougwilson dougwilson added the pr label Feb 14, 2017
@ghost
Copy link
Author

ghost commented Feb 15, 2017

What do you think about this? I get that you have a million PRs to go through but it would be awesome if this could be merged for next release, it's not that big of a change and it would be really nice to have basic Express compatibility at the time I release my next version 👍

@dougwilson
Copy link
Contributor

Yea, it would definitely be something for the next minor. It would be really nice if it could actually be generic for help towards http2 / shot and the others and not specific to uws, but at the very least we can use this as the jumping off point for what would end up landing in the next minor to be generic.

Right now, it doesn't add anything you cannot do, rather just adds a convince method that is specific to a single alternative implementation without helping move forward the others, if that makes sense.

We haven't gotten together to talk about it just yet, but those are my initial thoughts we'll need to hash out.

@ghost
Copy link
Author

ghost commented Feb 17, 2017

I guess I could make some helper function to ease the use of those Object.setPrototypeOf calls

@ghost ghost closed this Feb 17, 2017
@dougwilson dougwilson self-assigned this Feb 20, 2017
This pull request was closed.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant