Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

use watcher instead of polling #1

Closed
extrawurst opened this issue Mar 22, 2020 · 4 comments
Closed

use watcher instead of polling #1

extrawurst opened this issue Mar 22, 2020 · 4 comments
Labels
enhancement New feature or request pinned

Comments

@extrawurst
Copy link
Collaborator

use notify to watch git instead of permanent polling
@extrawurst extrawurst added the enhancement New feature or request label Mar 30, 2020
@stale stale bot added the wontfix This will not be worked on label May 29, 2020
@gitui-org gitui-org deleted a comment from stale bot May 29, 2020
@stale stale bot removed the wontfix This will not be worked on label May 29, 2020
@extrawurst extrawurst mentioned this issue Jun 29, 2020
Closed
@extrawurst
Copy link
Collaborator Author

unfortunately this introduces massive bloat of dependencies and reintroduces the outdated mio 0.6 with its security problematic outdated net2: notify-rs/notify#248

extrawurst pushed a commit that referenced this issue Jul 18, 2020
use file watcher based on notify crate instead of regular polling (#1)
91a0cb9
extrawurst pushed a commit that referenced this issue Jul 18, 2020
Merge branch 'master' into use-file-watcher-#1
94972d3
@extrawurst extrawurst mentioned this issue Feb 19, 2021
Closed
This was referenced Jun 3, 2021
Closed
Closed
@0xpr03
Copy link

0xpr03 commented Aug 23, 2021

Note: We're not depending on mio 0.6 anymore

@extrawurst
Copy link
Collaborator Author

@0xpr03 yeah but I am waiting for a stable release of 5.0

@extrawurst
Copy link
Collaborator Author

extrawurst commented Nov 25, 2021 •
edited
Loading

or I am just using https://github.com/facebook/watchman

ok that requires another binary to be installed - what a joke

@extrawurst extrawurst mentioned this issue Sep 1, 2022
Merged
@unixoidal unixoidal mentioned this issue Feb 17, 2023
Open
@hadronized hadronized mentioned this issue Mar 2, 2023
Open
@extrawurst extrawurst mentioned this issue Apr 17, 2023
Closed
blaggacao pushed a commit to blaggacao/gitui that referenced this issue Feb 20, 2024
@hendrikmaus
Merge pull request gitui-org#1 from utkarshgupta137/gpg-commit-signing
24bb8ac 
add workaround for amending & rewording signed commits
@BrunoWallner BrunoWallner mentioned this issue Mar 14, 2024
Closed
IndianBoy42 pushed a commit to IndianBoy42/gitui that referenced this issue Jun 4, 2024
@extrawurst @IndianBoy42
File watching using notify (gitui-org#1310)
cdd26b9 
closes gitui-org#1
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement New feature or request pinned
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@extrawurst @0xpr03