Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Failing to locate the content document for RSS documents, dereferencing null #46

Closed
eyalroz opened this issue Feb 15, 2021 · 2 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@eyalroz
Copy link
Owner

eyalroz commented Feb 15, 2021

In some cases - specifically, when reading RSS-obtained documents sometimes, I can't cycle directions:

  cycleDirectionSettings : function() {
    var messagePane = document.getElementById("messagepane");
    var body = messagePane.contentDocument.body;
    var newForcedDirection;
    switch (body.getAttribute('bidimailui-forced-direction')) {
      case 'ltr':
        newForcedDirection = 'rtl';
        break;
      case 'rtl':
        newForcedDirection = null;
        break;
      default: // should be null
        newForcedDirection = 'ltr';
    }

messagepane is not null, but the contentDocument is missing/null. So, we fail to get the body.

@eyalroz eyalroz added the bug Something isn't working label Feb 15, 2021
@eyalroz eyalroz self-assigned this Feb 15, 2021
@eyalroz eyalroz changed the title Failing to locathe content document, dereferencing null Failing to locath the content document, dereferencing null Feb 15, 2021
@eyalroz
Copy link
Owner Author

eyalroz commented Feb 15, 2021

Also getting a failure in:

  gatherParameters : function() {
    if (!msgWindow) { return [null, null, null]; }
    let domDocument =  msgWindow.messageWindowDocShell.contentViewer.DOMDocument;

sometimes.

@eyalroz eyalroz changed the title Failing to locath the content document, dereferencing null Failing to locate the content document, dereferencing null Aug 28, 2021
@eyalroz eyalroz changed the title Failing to locate the content document, dereferencing null Failing to locate the content document for RSS documents, dereferencing null Aug 10, 2023
@eyalroz
Copy link
Owner Author

eyalroz commented Aug 17, 2023

This should be resolved by the commits fixing bug #97 for TB 115 and later.

@eyalroz eyalroz closed this as completed Aug 17, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant