Skip to content

Commit 62b3bf9

Browse files
committed
Remove unused e2e lines
1 parent 0f5e1b1 commit 62b3bf9

File tree

2 files changed

+0
-36
lines changed

2 files changed

+0
-36
lines changed

tasks/e2e-installs.sh

-10
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@ temp_app_path=`mktemp -d 2>/dev/null || mktemp -d -t 'temp_app_path'`
2222
function cleanup {
2323
echo 'Cleaning up.'
2424
cd $root_path
25-
# Uncomment when snapshot testing is enabled by default:
26-
# rm ./packages/react-scripts/template/src/__snapshots__/App.test.js.snap
2725
rm -rf $temp_cli_path $temp_app_path
2826
}
2927

@@ -60,14 +58,6 @@ root_path=$PWD
6058

6159
npm install
6260

63-
# If the node version is < 4, the script should just give an error.
64-
if [ `node --version | sed -e 's/^v//' -e 's/\..\+//g'` -lt 4 ]
65-
then
66-
cd $temp_app_path
67-
err_output=`node "$root_path"/packages/create-react-app/index.js test-node-version 2>&1 > /dev/null || echo ''`
68-
[[ $err_output =~ You\ are\ running\ Node ]] && exit 0 || exit 1
69-
fi
70-
7161
if [ "$USE_YARN" = "yes" ]
7262
then
7363
# Install Yarn so that the test can use it to install packages.

tasks/e2e-kitchensink.sh

-26
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@ temp_app_path=`mktemp -d 2>/dev/null || mktemp -d -t 'temp_app_path'`
2222
function cleanup {
2323
echo 'Cleaning up.'
2424
cd $root_path
25-
# Uncomment when snapshot testing is enabled by default:
26-
# rm ./packages/react-scripts/template/src/__snapshots__/App.test.js.snap
2725
rm -rf $temp_cli_path $temp_app_path
2826
}
2927

@@ -60,14 +58,6 @@ root_path=$PWD
6058

6159
npm install
6260

63-
# If the node version is < 4, the script should just give an error.
64-
if [ `node --version | sed -e 's/^v//' -e 's/\..\+//g'` -lt 4 ]
65-
then
66-
cd $temp_app_path
67-
err_output=`node "$root_path"/packages/create-react-app/index.js test-node-version 2>&1 > /dev/null || echo ''`
68-
[[ $err_output =~ You\ are\ running\ Node ]] && exit 0 || exit 1
69-
fi
70-
7161
if [ "$USE_YARN" = "yes" ]
7262
then
7363
# Install Yarn so that the test can use it to install packages.
@@ -93,9 +83,6 @@ cp package.json package.json.orig
9383
# of those packages.
9484
node $root_path/tasks/replace-own-deps.js
9585

96-
# Remove .npmignore so the test template is added
97-
rm $root_path/packages/react-scripts/.npmignore
98-
9986
# Finally, pack react-scripts
10087
scripts_path=$root_path/packages/react-scripts/`npm pack`
10188

@@ -153,13 +140,6 @@ E2E_FILE=./build/index.html \
153140
NODE_PATH=src \
154141
node_modules/.bin/mocha --require babel-register --require babel-polyfill integration/*.test.js
155142

156-
# Uncomment when snapshot testing is enabled by default:
157-
# test -e src/__snapshots__/App.test.js.snap
158-
159-
# Test the server
160-
REACT_APP_SHELL_ENV_MESSAGE=fromtheshell NODE_PATH=src npm start -- --smoke-test
161-
REACT_APP_SHELL_ENV_MESSAGE=fromtheshell HTTPS=true NODE_PATH=src npm start -- --smoke-test
162-
163143
# ******************************************************************************
164144
# Finally, let's check that everything still works after ejecting.
165145
# ******************************************************************************
@@ -208,11 +188,5 @@ E2E_FILE=./build/index.html \
208188
NODE_PATH=src \
209189
node_modules/.bin/mocha --require babel-register --require babel-polyfill integration/*.test.js
210190

211-
# Uncomment when snapshot testing is enabled by default:
212-
# test -e src/__snapshots__/App.test.js.snap
213-
214-
# Test the server
215-
REACT_APP_SHELL_ENV_MESSAGE=fromtheshell NODE_PATH=src npm start -- --smoke-test
216-
217191
# Cleanup
218192
cleanup

0 commit comments

Comments
 (0)