Relax ESLint version range (#6840)

* Relax eslint version range

* Use semver package to compare versions during preflight check

* Cleanup package.json files whitespace

Author: ianschmitz

packages/babel-plugin-named-asset-import/package.json

@@ -3,8 +3,8 @@
   "version": "0.3.1",
   "description": "Babel plugin for named asset imports in Create React App",
   "repository": {
-    "type" : "git",
-    "url" : "https://github.com/facebook/create-react-app.git",
+    "type": "git",
+    "url": "https://github.com/facebook/create-react-app.git",
     "directory": "packages/babel-plugin-named-asset-import"
   },
   "license": "MIT",

packages/babel-preset-react-app/package.json

@@ -3,8 +3,8 @@
   "version": "7.0.2",
   "description": "Babel preset used by Create React App",
   "repository": {
-    "type" : "git",
-    "url" : "https://github.com/facebook/create-react-app.git",
+    "type": "git",
+    "url": "https://github.com/facebook/create-react-app.git",
     "directory": "packages/babel-preset-react-app"
   },
   "license": "MIT",

packages/confusing-browser-globals/package.json

@@ -8,8 +8,8 @@
     "test": "jest"
   },
   "repository": {
-    "type" : "git",
-    "url" : "https://github.com/facebook/create-react-app.git",
+    "type": "git",
+    "url": "https://github.com/facebook/create-react-app.git",
     "directory": "packages/confusing-browser-globals"
   },
   "keywords": [

packages/create-react-app/package.json

@@ -6,8 +6,8 @@
   ],
   "description": "Create React apps with no build configuration.",
   "repository": {
-    "type" : "git",
-    "url" : "https://github.com/facebook/create-react-app.git",
+    "type": "git",
+    "url": "https://github.com/facebook/create-react-app.git",
     "directory": "packages/create-react-app"
   },
   "license": "MIT",
@@ -33,7 +33,7 @@
     "fs-extra": "7.0.1",
     "hyperquest": "2.1.3",
     "inquirer": "6.2.2",
-    "semver": "5.6.0",
+    "semver": "6.0.0",
     "tar-pack": "3.4.1",
     "tmp": "0.0.33",
     "validate-npm-package-name": "3.0.0"

packages/eslint-config-react-app/package.json

@@ -3,8 +3,8 @@
   "version": "3.0.8",
   "description": "ESLint configuration used by Create React App",
   "repository": {
-    "type" : "git",
-    "url" : "https://github.com/facebook/create-react-app.git",
+    "type": "git",
+    "url": "https://github.com/facebook/create-react-app.git",
     "directory": "packages/eslint-config-react-app"
   },
   "license": "MIT",

packages/react-app-polyfill/package.json

@@ -3,8 +3,8 @@
   "version": "0.2.2",
   "description": "Polyfills for various browsers including commonly used language features",
   "repository": {
-    "type" : "git",
-    "url" : "https://github.com/facebook/create-react-app.git",
+    "type": "git",
+    "url": "https://github.com/facebook/create-react-app.git",
     "directory": "packages/react-app-polyfill"
   },
   "license": "MIT",

packages/react-dev-utils/package.json

@@ -3,8 +3,8 @@
   "version": "8.0.0",
   "description": "Webpack utilities used by Create React App",
   "repository": {
-    "type" : "git",
-    "url" : "https://github.com/facebook/create-react-app.git",
+    "type": "git",
+    "url": "https://github.com/facebook/create-react-app.git",
     "directory": "packages/react-dev-utils"
   },
   "license": "MIT",

packages/react-error-overlay/package.json

@@ -11,8 +11,8 @@
     "build:prod": "cross-env NODE_ENV=production node build.js"
   },
   "repository": {
-    "type" : "git",
-    "url" : "https://github.com/facebook/create-react-app.git",
+    "type": "git",
+    "url": "https://github.com/facebook/create-react-app.git",
     "directory": "packages/react-error-overlay"
   },
   "license": "MIT",
@@ -44,7 +44,7 @@
     "chalk": "^2.4.2",
     "chokidar": "^2.1.2",
     "cross-env": "5.2.0",
-    "eslint": "5.16.0",
+    "eslint": "^5.16.0",
     "eslint-config-react-app": "^3.0.8",
     "eslint-plugin-flowtype": "2.50.1",
     "eslint-plugin-import": "2.16.0",

packages/react-scripts/package.json

@@ -3,8 +3,8 @@
   "version": "2.1.8",
   "description": "Configuration and scripts for Create React App.",
   "repository": {
-    "type" : "git",
-    "url" : "https://github.com/facebook/create-react-app.git",
+    "type": "git",
+    "url": "https://github.com/facebook/create-react-app.git",
     "directory": "packages/react-scripts"
   },
   "license": "MIT",
@@ -41,7 +41,7 @@
     "css-loader": "2.1.1",
     "dotenv": "6.2.0",
     "dotenv-expand": "4.2.0",
-    "eslint": "5.16.0",
+    "eslint": "^5.16.0",
     "eslint-config-react-app": "^3.0.8",
     "eslint-loader": "2.1.2",
     "eslint-plugin-flowtype": "2.50.1",
@@ -70,6 +70,7 @@
     "react-dev-utils": "^8.0.0",
     "resolve": "1.10.0",
     "sass-loader": "7.1.0",
+    "semver": "6.0.0",
     "style-loader": "0.23.1",
     "terser-webpack-plugin": "1.2.3",
     "url-loader": "1.1.2",

packages/react-scripts/scripts/utils/verifyPackageTree.js

@@ -10,6 +10,7 @@
 
 const chalk = require('react-dev-utils/chalk');
 const fs = require('fs');
+const semver = require('semver');
 const path = require('path');
 
 // We assume that having wrong versions of these
@@ -74,7 +75,7 @@ function verifyPackageTree() {
         fs.readFileSync(maybeDepPackageJson, 'utf8')
       );
       const expectedVersion = expectedVersionsByDep[dep];
-      if (depPackageJson.version !== expectedVersion) {
+      if (!semver.satisfies(depPackageJson.version, expectedVersion)) {
         console.error(
           chalk.red(
             `\nThere might be a problem with the project dependency tree.\n` +