Jest.mock does not resolve modules correctly when NODE_PATH is set

[dapids]

Description

Running tests with NODE_PATH=src npm test.

Expected behavior

jest.mock('my_module') should be resolved to src/my_module.

Actual behavior

jest.mock('my_module') does not resolve to src/my_module.

Environment

1. npm ls react-scripts (if you haven’t ejected): 0.8.4
2. node -v: v6.9.2
3. npm -v: 3.10.9

[EnoahNetzach]

@mzuccala could you please update react-scripts to v0.9.0 and confirm that tests are still green?

[gaearon]

I verified that this indeed happens, but only if you import it relatively in jest.mock call but absolutely in the app code, or vice versa. This doesn’t seem to happen if you import files consistently in one way or another both in app and jest.mock() calls. So the workaround is to use a consistent convention across your whole app.

I agree this seems like a big, and I filed it as jestjs/jest#3069. It is highly unlikely that we can do anything about it on our side, so I’ll close this issue. Please feel free to track jestjs/jest#3069 (and maybe even contribute a fix!)

[gaearon]

This was fixed in react-scripts@1.0.1.