-
-
Notifications
You must be signed in to change notification settings - Fork 27k
Check for accidental extraneous dependencies in end-to-end-tests #1720
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
@gaearon @Timer,
This will get between the word dependencies and the closing bracket below the dependencies, i only need to check if every dependency is correct. |
I've been a bit busy, @lpalmes -- sorry for not giving you a quicker response. awk '/dependencies/{y=1;next}/},/{y=0; next}y' package.json | \
grep -v -q -E '^\s*"react(?:-dom|-scripts)?"'
Then just test to make sure the result of that is not 0, because 0 would mean it found something extraneous! |
@lpalmes Hi! How's everything going? |
I was traveling, got back yesterday, sorry for the absence. |
Sweet, thanks @lpalmes! |
Thanks @Timer, i've enjoyed it and managed to meet lot of developers and companies, just what i was looking for 😄 , really great experience. |
See the discussion in #1685 (comment).
@lpalmes might want to work on this so please don’t jump on the issue yet unless you’re @lpalmes.
The text was updated successfully, but these errors were encountered: