Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

resolve paths in eslint config #173

Closed
ForbesLindesay opened this issue Jul 25, 2016 · 7 comments
Closed

resolve paths in eslint config #173

ForbesLindesay opened this issue Jul 25, 2016 · 7 comments
Milestone

Comments

@ForbesLindesay
Copy link
Contributor

ForbesLindesay commented Jul 25, 2016

Paths to plugins in eslint should be fully resolved in the same way they are in babel's config.

See comment: #149 (comment)

Without this, editor plugins will fail to find the local eslint config.

@gaearon
Copy link
Contributor

gaearon commented Jul 25, 2016

Thanks for explaining. Would you like to make a PR?

@ForbesLindesay
Copy link
Contributor Author

Happy for someone else to fix if they get there first :)

@gaearon gaearon added this to the 0.2.0 milestone Jul 25, 2016
@gaearon
Copy link
Contributor

gaearon commented Jul 26, 2016

I looked at this, and it is just not possible right now: eslint/eslint#3458. However there seems to be discussion on implementing it so it‘s not too bad.

This is only a problem with npm 2 (and in very rare cases with npm 3 but we shouldn’t hit those cases). So I think we can punt on this for now.

Longer term, I think something like #215 would be the right solution, but it requires buy-in from the tool vendors.

@gaearon gaearon closed this as completed Jul 26, 2016
@ForbesLindesay
Copy link
Contributor Author

It works fine. I do it in https://github.com/ForbesLindesay/eslint-config-forbeslindesay/blob/master/index.js and have been using this extensively without issue.

@ForbesLindesay
Copy link
Contributor Author

OK, doesn't work with "plugins" apparently, only parser.

@gaearon
Copy link
Contributor

gaearon commented Jul 26, 2016

Yeah. 😢

@ForbesLindesay
Copy link
Contributor Author

I would attempt to help fixing this, but I don't want to repeat my past experiences of attempting to contribute to eslint.

@lock lock bot locked and limited conversation to collaborators Jan 23, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

No branches or pull requests

2 participants