Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Q: contributing to the project from windows #2828

Closed
Dubes opened this issue Jul 20, 2017 · 4 comments
Closed

Q: contributing to the project from windows #2828

Dubes opened this issue Jul 20, 2017 · 4 comments

Comments

@Dubes
Copy link
Contributor

Dubes commented Jul 20, 2017

I am trying to contribute but it is more convenient for me to use a windows machine. However, many commands don't run. for e.x. npm run create-react-app fails as it tries to treat tasks as an npm module and not a directory where scripts can be found. npm run format fails as well. I also tried with git bash.

I am wondering if any contributors use a windows machine and if they have any tips they can share.

Other details
Windows 10
Node: v6.9.1
npm: 4.6.1

@Timer
Copy link
Contributor

Timer commented Jul 20, 2017

We know this is a pain point, and we would love pull requests that make the development better on Windows machines.

npm run format should be an easy fix; you might need to switch from apostrophes to quotes or vice versa.

@Dubes
Copy link
Contributor Author

Dubes commented Jul 21, 2017

I will try to check if I can improve something there

@cr101
Copy link
Contributor

cr101 commented Jul 23, 2017

@Dubes @Timer Once this PR #2309 is merged Windows users will be able to contribute.
I've been using tasks/cra.js from that PR on my Windows 10 machine and it's been working fine.

@Dubes
Copy link
Contributor Author

Dubes commented Jul 27, 2017

Closing as it has been aggregated in #2855

@Dubes Dubes closed this as completed Jul 27, 2017
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants