Skip to content

How to overcome Issue 1881 #3161

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
porschberg opened this issue Sep 20, 2017 · 4 comments
Closed

How to overcome Issue 1881 #3161

porschberg opened this issue Sep 20, 2017 · 4 comments

Comments

@porschberg
Copy link

This is not a bug report ;-). The bug #1881 was already closed.
However I cloned a project which was originally generated by CRA. I developed it in my direction and now I observed Issue 1881 (exactly the same).
The issue was closed with 4b92fd3 .

The problem in the issue seems to be the ansi-html module.
In my project I have
"react-dev-utils": "^0.4.2",
in my package.json.
This version of react-dev-utils references ansi-html in exactly version 0.0.5 which caused the bug above.
Current version of ansi-html is 0.0.7. In this version the trailing coma is deleted and it should all be fine.
However, when I simply replace react-dev-utils 0.4.2 with react-dev-utils 4.0.1 I get other errors.
What would be a sensible upgrade path?

@Timer
Copy link
Contributor

Timer commented Sep 20, 2017

@porschberg unfortunately there was never a version of 0.9.x released which included the upgraded copy of ansi-html; so you'll need to fork the package and publish a corrected version yourself.

You could try react-dev-utils@1.0.1 and see if it works, it may.

The proper upgrade path would be to upgrade your CRA setup as a whole, maybe create a new project, eject it, and then copy the configuration over your current setup -- re-adding any modifications you had to make.

Unfortunately, ejecting puts you in a bad position -- you stop receiving updates, and it requires manual tracking to stay up to date.

Can I ask why you ejected in the first place, out of curiosity? You may be able to un-eject, as we've added new features since < 0.9.x.

@porschberg
Copy link
Author

This was fast, thank you. I tried react-dev-utils@1.0.3 but there seems a similar problem with IE11 and trailing coma. This time it comes from webpackHotDevClient.js

    // Connect to WebpackDevServer via a socket.
    var connection = new SockJS(
        url.format({
         protocol: window.location.protocol,
         hostname: window.location.hostname,
         port: window.location.port,
         // Hardcoded in WebpackDevServer
          pathname: '/sockjs-node',
        })
     );

@Timer
Copy link
Contributor

Timer commented Sep 20, 2017

Yikes! I have not a clue when we could've fixed it then 😞.

Could you try to upgrade to the latest version? If that still has a problem we can talk about fixing it and getting a release out.

Alternatively, you can fork the package and publish that corrected version yourself.

@Timer
Copy link
Contributor

Timer commented Sep 29, 2017

Closing this as unactionable, hope you figured this out!

@Timer Timer closed this as completed Sep 29, 2017
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

No branches or pull requests

2 participants