Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix Yarn PnP after ejecting #5215

Closed
gaearon opened this issue Oct 1, 2018 · 5 comments
Closed

Fix Yarn PnP after ejecting #5215

gaearon opened this issue Oct 1, 2018 · 5 comments
Milestone

Comments

@gaearon
Copy link
Contributor

gaearon commented Oct 1, 2018

Currently you'd have to move Jest config out of package.json manually to make PnP work after you eject. See #5214.

@gaearon
Copy link
Contributor Author

gaearon commented Oct 1, 2018

cc @arcanis

@Timer Timer added this to the 2.0.x milestone Oct 1, 2018
@arcanis
Copy link
Contributor

arcanis commented Oct 5, 2018

Same thing for the Babel config, that should be put in a .babelrc.js. The ejection puts the preset list in the package.json, which causes issues when Babel tries to resolve the presets (it's the reason why the webpack config files uses require.resolve: Babel uses the resolve package to locate the presets when they're not absolute paths, which only supports the node_modules resolution).

@gaearon
Copy link
Contributor Author

gaearon commented Oct 5, 2018

Both sounds fine to me. But I'd prefer to avoid dotfiles because they're invisible when copying.

@fazouane-marouane
Copy link

FYI, with babel7 we can use a babel.config.js file (so not leading dot)

module.exports = {
  presets: ["react-app"],
};

@iansu iansu modified the milestones: 2.1.x, 3.x Mar 10, 2019
@mrmckeb
Copy link
Contributor

mrmckeb commented Jun 16, 2021

Is this still an issue today? If so can we raise a new issue?

@mrmckeb mrmckeb closed this as completed Jun 16, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

6 participants