Skip to content

Confused about SVG files in 'Adding Images, Fonts, and Files' documentation #6073

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
dkns opened this issue Dec 20, 2018 · 3 comments
Closed
Labels

Comments

@dkns
Copy link

dkns commented Dec 20, 2018

Hello. Docs (https://github.com/facebook/create-react-app/blob/master/docusaurus/docs/adding-images-fonts-and-files.md) say that:

This applies to the following file extensions: bmp, gif, jpg, jpeg, and png. SVG files are excluded due to #1153.

Yet in next section we read:

One way to add SVG files was described in the section above.

I'm assuming that you can now import SVG files the same way as described in first section since #1153 seems to be fixed: #1180

@jontro
Copy link

jontro commented Dec 20, 2018

While we're at it the documentation says nothing about font files. Just tried importing an otf file which surprisingly gives you a module not found error.

@stale
Copy link

stale bot commented Jan 26, 2019

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Jan 26, 2019
@stale
Copy link

stale bot commented Feb 7, 2019

This issue has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue.

@stale stale bot closed this as completed Feb 7, 2019
@lock lock bot locked and limited conversation to collaborators Feb 12, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants