Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update dotenv-expand (again) to 5.x to resolve previously closed issues #7577

Closed
kireerik opened this issue Aug 21, 2019 · 5 comments · Fixed by #7531
Closed

Update dotenv-expand (again) to 5.x to resolve previously closed issues #7577

kireerik opened this issue Aug 21, 2019 · 5 comments · Fixed by #7531

Comments

@kireerik
Copy link
Contributor

kireerik commented Aug 21, 2019

issue to resolve: #4002 (This is was probably never resolved (https://github.com/facebook/create-react-app/blob/master/CHANGELOG-2.x.md#203-october-1-2018 #4009) or could be a regression.)

@gaearon, @iansu As we can see dotenv-expand is not up to date:

dotenv-expand@4.2.0:
version "4.2.0"

motdotla/dotenv-expand@f012c66

@heyimalex
Copy link
Contributor

You're sure this is still happening? The bug was in dotenv, not dotenv-expand, and we're currently pinned to dotenv 6.2.0 so that fix definitely landed.

@kireerik
Copy link
Contributor Author

Yes, I am.

The issue was in dotenv-expand: #4002 (comment)

This is the exact commit with the resolution in the dotenv-expand repository: motdotla/dotenv-expand@f012c66

@kireerik
Copy link
Contributor Author

#5833 (comment)

@kireerik
Copy link
Contributor Author

motdotla/dotenv-expand#18 (comment)

@heyimalex I found an open pull request: #7531

This would solve the issue.

@heyimalex
Copy link
Contributor

Forgive me :)

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants