From 4a4cfef89ed1e8e1a27ef208946cfcc328dc3925 Mon Sep 17 00:00:00 2001 From: Victor Amupitan Date: Mon, 22 May 2017 00:31:38 -0500 Subject: [PATCH 1/3] Changes no-unused-expressions lint from warning to error --- packages/eslint-config-react-app/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/eslint-config-react-app/index.js b/packages/eslint-config-react-app/index.js index 3dcce554046..386a34d6929 100644 --- a/packages/eslint-config-react-app/index.js +++ b/packages/eslint-config-react-app/index.js @@ -181,7 +181,7 @@ module.exports = { 'no-unexpected-multiline': 'warn', 'no-unreachable': 'warn', 'no-unused-expressions': [ - 'warn', + 'error', { allowShortCircuit: true, allowTernary: true, From 4b9c678820e92f15f0e7b8dba7736277dd512842 Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Tue, 16 Jan 2018 16:23:49 +0000 Subject: [PATCH 2/3] Update index.js --- packages/eslint-config-react-app/index.js | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/eslint-config-react-app/index.js b/packages/eslint-config-react-app/index.js index 386a34d6929..528d568f429 100644 --- a/packages/eslint-config-react-app/index.js +++ b/packages/eslint-config-react-app/index.js @@ -184,6 +184,7 @@ module.exports = { 'error', { allowShortCircuit: true, + allowTaggedTemplates: true, allowTernary: true, }, ], From 92093efc6bfd098aa1924612d54670ee0d278dc0 Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Tue, 16 Jan 2018 18:42:49 +0000 Subject: [PATCH 3/3] Update index.js --- packages/eslint-config-react-app/index.js | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/eslint-config-react-app/index.js b/packages/eslint-config-react-app/index.js index 528d568f429..386a34d6929 100644 --- a/packages/eslint-config-react-app/index.js +++ b/packages/eslint-config-react-app/index.js @@ -184,7 +184,6 @@ module.exports = { 'error', { allowShortCircuit: true, - allowTaggedTemplates: true, allowTernary: true, }, ],