From cec8f0d7b5af4fb61a4caeed5edbea13b19053fc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mateusz=20Burzy=C5=84ski?= Date: Wed, 9 Jan 2019 15:43:11 +0100 Subject: [PATCH 1/3] Suggests that tsconfig.json is incorrect only when SyntaxError is caught --- .../scripts/utils/verifyTypeScriptSetup.js | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/packages/react-scripts/scripts/utils/verifyTypeScriptSetup.js b/packages/react-scripts/scripts/utils/verifyTypeScriptSetup.js index 370c7176e19..f60f6717e7e 100644 --- a/packages/react-scripts/scripts/utils/verifyTypeScriptSetup.js +++ b/packages/react-scripts/scripts/utils/verifyTypeScriptSetup.js @@ -172,13 +172,16 @@ function verifyTypeScriptSetup() { parsedCompilerOptions = result.options; } catch (e) { - console.error( - chalk.red.bold( - 'Could not parse', - chalk.cyan('tsconfig.json') + '.', - 'Please make sure it contains syntactically correct JSON.' - ) - ); + if (e && e.name === 'SyntaxError') { + console.error( + chalk.red.bold( + 'Could not parse', + chalk.cyan('tsconfig.json') + '.', + 'Please make sure it contains syntactically correct JSON.' + ) + ); + } + console.error(e && e.message ? `Details: ${e.message}` : ''); process.exit(1); } From 322b289fa756d513841949476872fba45dcf1359 Mon Sep 17 00:00:00 2001 From: Ian Sutherland Date: Tue, 2 Apr 2019 21:01:52 -0600 Subject: [PATCH 2/3] Update verifyTypeScriptSetup.js --- packages/react-scripts/scripts/utils/verifyTypeScriptSetup.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-scripts/scripts/utils/verifyTypeScriptSetup.js b/packages/react-scripts/scripts/utils/verifyTypeScriptSetup.js index f60f6717e7e..14c2ae1ac94 100644 --- a/packages/react-scripts/scripts/utils/verifyTypeScriptSetup.js +++ b/packages/react-scripts/scripts/utils/verifyTypeScriptSetup.js @@ -182,7 +182,7 @@ function verifyTypeScriptSetup() { ); } - console.error(e && e.message ? `Details: ${e.message}` : ''); + console.error(e && e.message ? `${e.message}` : ''); process.exit(1); } From fb6b6299c5d72497900ea55d464747493067b067 Mon Sep 17 00:00:00 2001 From: Ian Sutherland Date: Tue, 2 Apr 2019 21:21:29 -0600 Subject: [PATCH 3/3] Update verifyTypeScriptSetup.js --- packages/react-scripts/scripts/utils/verifyTypeScriptSetup.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-scripts/scripts/utils/verifyTypeScriptSetup.js b/packages/react-scripts/scripts/utils/verifyTypeScriptSetup.js index 14c2ae1ac94..b44431d7038 100644 --- a/packages/react-scripts/scripts/utils/verifyTypeScriptSetup.js +++ b/packages/react-scripts/scripts/utils/verifyTypeScriptSetup.js @@ -182,7 +182,7 @@ function verifyTypeScriptSetup() { ); } - console.error(e && e.message ? `${e.message}` : ''); + console.log(e && e.message ? `${e.message}` : ''); process.exit(1); }