Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Navbar line break in create react app docusaurus site #2121

Closed
andriijas opened this issue Dec 13, 2019 · 5 comments · Fixed by #2372
Closed

Navbar line break in create react app docusaurus site #2121

andriijas opened this issue Dec 13, 2019 · 5 comments · Fixed by #2372
Labels
bug An error in the Docusaurus core causing instability or issues with its execution

Comments

@andriijas
Copy link

🐛 Bug Report

There's a strange styling bug, potentially from infima that makes the header on the docusaurus site for create react app line break in Safari (no other browser).

I tried to reproduce it on other sites without success.

I tried to fix it naively in facebook/create-react-app#7831 but that would cause other issues as described in the comments.

To Reproduce

Open safari
go to https://create-react-app.dev

Expected behavior

Navbar header title in one line

Actual Behavior

Navbar header title line breaks

66916348-51e11700-f01b-11e9-9133-06dabbf36bea

@andriijas andriijas added bug An error in the Docusaurus core causing instability or issues with its execution status: needs triage This issue has not been triaged by maintainers labels Dec 13, 2019
@endiliey endiliey removed the status: needs triage This issue has not been triaged by maintainers label Dec 13, 2019
@elharony
Copy link

We can fix it by removing flex: 1 0 0; from .navbar .navbar__items. Not sure where to contribute it! 🤔

@esvyridov
Copy link

@andriijas Hi. I found a solution how we could make it looks like in Chrome. Does it look good to you? If so I'll do a PR for CRA
image

@andriijas
Copy link
Author

@esvyridov If you have better fix than this: facebook/create-react-app#7831 - yeah! Thanks!

@esvyridov
Copy link

@andriijas pr is ready - facebook/create-react-app#8437

@andriijas
Copy link
Author

Okay lets get that in for now. The underlaying CSS framework of docusaurus isn't open source I think. Hopefully will get notified from this issue if it changes :D

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug An error in the Docusaurus core causing instability or issues with its execution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants