Skip to content
This repository has been archived by the owner on Nov 2, 2019. It is now read-only.

Refactor UserProfilePictureView into UserProfile.PictureView. #34

Merged
merged 1 commit into from
Jul 27, 2016
Merged

Refactor UserProfilePictureView into UserProfile.PictureView. #34

merged 1 commit into from
Jul 27, 2016

Conversation

nlutsenko
Copy link
Contributor

No description provided.

@nlutsenko nlutsenko added this to the 0.2.0 milestone Jul 26, 2016
@ghost ghost added GH Review: review-needed CLA Signed The Facebook CLA has been signed labels Jul 26, 2016
@nlutsenko nlutsenko added enhancement Adds a feature or improvement GH Review: review-needed CLA Signed The Facebook CLA has been signed and removed CLA Signed The Facebook CLA has been signed GH Review: review-needed labels Jul 26, 2016
@nlutsenko nlutsenko merged commit e41ee3a into master Jul 27, 2016
@nlutsenko nlutsenko deleted the nlutsenko.userProfile.pictureView branch July 27, 2016 20:56
@AndrewSB
Copy link
Contributor

@nlutsenko this refactor seems interesting - what are your thoughts on naming a .swift file with a . instead of nesting it inside a subfolder?

i.e. src/UserProfile.PictureView.swift vs src/UserProfile/PictureView.swift

@nlutsenko
Copy link
Contributor Author

Personal preference of me and @richardjrossiii is the major reason for using this convention.
Also, using a nested name, or full symbol name for the file name simplifies quick open (⇧+⌘+O in Xcode), as well as file search on GitHub and many other source editors.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers
No reviews
Assignees

@nlutsenko nlutsenko

Labels
CLA Signed The Facebook CLA has been signed enhancement Adds a feature or improvement
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nlutsenko @AndrewSB @richardjrossiii