Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove "Failed Composite propType" checking from warning #152

Closed
keyz opened this issue May 23, 2016 · 1 comment
Closed

Remove "Failed Composite propType" checking from warning #152

keyz opened this issue May 23, 2016 · 1 comment

Comments

@keyz
Copy link
Contributor

keyz commented May 23, 2016

facebook/react#6824 removed duplicate propType checking, therefore the blacklist at https://github.com/facebook/fbjs/blob/master/src/__forks__/warning.js#L34-L36 is no longer necessary. Should we remove it from here? @spicyj
@keyz keyz changed the title Remove "Failed Composite propType" checking in warning Remove "Failed Composite propType" checking from warning May 23, 2016
@sophiebits
Copy link
Contributor

Yes, I mentioned that in facebook/react#6791. :) Send a PR?

@keyz keyz mentioned this issue May 23, 2016
Closed
@keyz keyz closed this as completed Jul 18, 2016
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sophiebits @keyz