Skip to content
This repository was archived by the owner on Nov 22, 2024. It is now read-only.

Network plugin - support mocks in imported devices #2040

Closed
wants to merge 1 commit into from
Closed

Network plugin - support mocks in imported devices #2040

wants to merge 1 commit into from

Conversation

bizzguy
Copy link
Contributor

@bizzguy bizzguy commented Mar 8, 2021

Summary

It is not currently possible to create mock routes from imported network logs. This PR will provide that functionality.

See this issue for more details: #1988

Changelog

Network plugin - create mocks from imported network logs

Test Plan

Use sample app to create network activity
Export network activity
Import network activity
Create mocks from imported network activity
Verify that mocks work using sample app

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 8, 2021
@coveralls
Copy link

coveralls commented Mar 8, 2021

Pull Request Test Coverage Report for Build 634074238

  • 7 of 11 (63.64%) changed or added relevant lines in 1 file are covered.
  • 12 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.007%) to 45.515%

Changes Missing Coverage Covered Lines Changed/Added Lines %
desktop/plugins/network/index.tsx 7 11 63.64%
Files with Coverage Reduction New Missed Lines %
desktop/app/src/sandy-chrome/appinspect/LaunchEmulator.tsx 2 61.76%
desktop/app/src/utils/iOSContainerUtility.tsx 2 35.19%
desktop/app/src/MenuBar.tsx 8 29.85%
Totals Coverage Status
Change from base Build 633543137: 0.007%
Covered Lines: 6119
Relevant Lines: 12181

💛 - Coveralls

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@passy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@passy
Copy link
Member

passy commented Mar 10, 2021

Amazing! Thanks for keeping the improvements coming, @bizzguy!

@facebook-github-bot
Copy link
Contributor

@passy merged this pull request in f61b5a1.

facebook-github-bot referenced this pull request Mar 15, 2021
…tNativeFlipperExample (#2063)

Summary:
Bumps [react-native-flipper](https://github.com/facebook/flipper) from 0.79.1 to 0.80.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/facebook/flipper/releases">react-native-flipper's releases</a>.</em></p>
<blockquote>
<h2>v0.80.0</h2>
<p>See <a href="https://github.com/facebook/flipper/blob/master/desktop/static/CHANGELOG.md">https://github.com/facebook/flipper/blob/master/desktop/static/CHANGELOG.md</a>
for full notes.</p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/facebook/flipper/commit/59204328c3c004036b82330ad8ac2f746fd04695"><code>5920432</code></a> Flipper Release: v0.80.0</li>
<li><a href="https://github.com/facebook/flipper/commit/c4cf46207b41915aafd421e42c1e664e2df82f96"><code>c4cf462</code></a> Upgrade docusaurus tools</li>
<li><a href="https://github.com/facebook/flipper/commit/f508a35ff92b353f316669fbba78b0204dd36329"><code>f508a35</code></a> Fix patch release versioning for open-source version</li>
<li><a href="https://github.com/facebook/flipper/commit/11f7af3e726bbe7d2cfb498da9bcef87e9ad6c80"><code>11f7af3</code></a> Bump robolectric from 4.4 to 4.5.1 (<a href="https://github.com/facebook/flipper/issues/2038">https://github.com/facebook/flipper/issues/2038</a>)</li>
<li><a href="https://github.com/facebook/flipper/commit/f61b5a1a86762fd140eb8927ce46d8fa8b4a8178"><code>f61b5a1</code></a> Network plugin - support mocks in imported devices (<a href="https://github.com/facebook/flipper/issues/2040">https://github.com/facebook/flipper/issues/2040</a>)</li>
<li><a href="https://github.com/facebook/flipper/commit/07defebb2253b934cd34c3dfd7625cbff5091c35"><code>07defeb</code></a> Bump hamcrest-library from 1.3 to 2.2 (<a href="https://github.com/facebook/flipper/issues/2041">https://github.com/facebook/flipper/issues/2041</a>)</li>
<li><a href="https://github.com/facebook/flipper/commit/2af4c4e1415b90e8610f6c67f8517875f84bec7b"><code>2af4c4e</code></a> Bump guava from 20.0 to 23.0 (<a href="https://github.com/facebook/flipper/issues/2034">https://github.com/facebook/flipper/issues/2034</a>)</li>
<li><a href="https://github.com/facebook/flipper/commit/58b2daea02da5cc48bb11b35637a3f463d2961b7"><code>58b2dae</code></a> Bundle all plugins script</li>
<li><a href="https://github.com/facebook/flipper/commit/c065760d150da6291e0d2f4aa69d4ff4a9a14a39"><code>c065760</code></a> Stable babel transformation cache key</li>
<li><a href="https://github.com/facebook/flipper/commit/baeb8ba5be8e0448df975457e4df09821060c30f"><code>baeb8ba</code></a> Performance improvements for &quot;build-plugin&quot; task</li>
<li>Additional commits viewable in <a href="https://github.com/facebook/flipper/compare/v0.79.1...v0.80.0">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=react-native-flipper&package-manager=npm_and_yarn&previous-version=0.79.1&new-version=0.80.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: #2063

Reviewed By: mweststrate

Differential Revision: D27046230

Pulled By: passy

fbshipit-source-id: 856f5b1c3312216a4f8f939417e858c0156c78cc
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants