This repository has been archived by the owner on Apr 20, 2023. It is now read-only.
Upgrade build web server PHP version to 7.4.9 #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the version used by the build script of PHP to 7.4.9. The previous version of PHP that was used was generating some errors in the latest version of Windows because of some missing libraries.
I went with version 7 and not version 8 because with the latter the web server scripts raise some exceptions, so in order to upgrade to PHP 8 we will have to upgrade the scripts too.
To test the PR you can run the build command and test the Windows build. As soon as you open the tool you should see the Preview tab showing the message "Open an article..." instead of just seeing the loading icon staying there forever.