-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Allow to pass findRelatedTests
and nonFlagArgs
to updateConfigAndRun
#10659
Conversation
Hi @whitecolor! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a changelog entry?
Also, and example watch plugin? Just so I understand the use case 🙂
@SimenB Added changelog entry and plugin example in PR desc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
findRelatedTests
and nonFlagArgs
to updateConfigAndRun
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Allow to pass
findRelatedTests
andnonFlagArgs
toupdateConfigAndRun
This is a need to make possible runtime changes of config to filter running tests based on for example FS watching events (in watch plugin).
Example of the plugin that makes jest run only tests related to a changed file.
Test plan
jest-core/__tests__/watch.test.js
updated to check if options pass.