-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Additional fix for #4444 to prevent errors on windows #11423
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11423 +/- ##
==========================================
- Coverage 69.32% 69.31% -0.01%
==========================================
Files 311 311
Lines 16241 16243 +2
Branches 4700 4701 +1
==========================================
Hits 11259 11259
- Misses 4954 4956 +2
Partials 28 28
Continue to review full report at Codecov.
|
This PR is stale because it has been open 1 year with no activity. Remove stale label or comment or this will be closed in 30 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, and sorry about the delay!
could you add a changelog entry?
if (e.code === 'ENOENT' && process.platform === 'win32') { | ||
return null; | ||
} | ||
|
||
e.message = `jest: failed to read cache file: ${cachePath}\nFailure message: ${e.message}`; | ||
removeFile(cachePath); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we call this as well?
I guess not since ENOENT
would probably be thrown again
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
See #4444 (comment)
I would love to get ay feedback on what kind of fix would be accepted, this is just one possibility.
Test plan
This issue is intermittent and windows only.