Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Additional fix for #4444 to prevent errors on windows #11423

Merged
merged 4 commits into from
Sep 28, 2022

Conversation

lukeapage
Copy link
Contributor

Summary

See #4444 (comment)

I would love to get ay feedback on what kind of fix would be accepted, this is just one possibility.

Test plan

This issue is intermittent and windows only.

@codecov-commenter
Copy link

Codecov Report

Merging #11423 (2c2d59b) into master (2047a36) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11423      +/-   ##
==========================================
- Coverage   69.32%   69.31%   -0.01%     
==========================================
  Files         311      311              
  Lines       16241    16243       +2     
  Branches     4700     4701       +1     
==========================================
  Hits        11259    11259              
- Misses       4954     4956       +2     
  Partials       28       28              
Impacted Files Coverage Δ
packages/jest-transform/src/ScriptTransformer.ts 78.57% <0.00%> (-0.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2047a36...2c2d59b. Read the comment docs.

@github-actions
Copy link

This PR is stale because it has been open 1 year with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Sep 16, 2022
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, and sorry about the delay!

could you add a changelog entry?

if (e.code === 'ENOENT' && process.platform === 'win32') {
return null;
}

e.message = `jest: failed to read cache file: ${cachePath}\nFailure message: ${e.message}`;
removeFile(cachePath);
Copy link
Member

@SimenB SimenB Sep 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we call this as well?

I guess not since ENOENT would probably be thrown again

@github-actions github-actions bot removed the Stale label Sep 16, 2022
@SimenB SimenB merged commit 4adf6ab into jestjs:main Sep 28, 2022
@SimenB
Copy link
Member

SimenB commented Sep 28, 2022

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants