Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

--showConfig support jest20 and jest21 #4575

Merged
merged 18 commits into from
Oct 1, 2017
Merged

Conversation

recca0120
Copy link
Contributor

make getConfig would be compatible with jest 20.x.x

@@ -1,8 +1,9 @@
/**
* Copyright (c) 2014-present, Facebook, Inc. All rights reserved.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
* This source code is licensed under the BSD-style license found in the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please bring back the old license header? Thanks.

@cpojer
Copy link
Member

cpojer commented Oct 1, 2017

Please make the tests pass and revert the license header. Thanks!

@codecov-io
Copy link

Codecov Report

Merging #4575 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4575      +/-   ##
==========================================
+ Coverage   55.61%   55.62%   +<.01%     
==========================================
  Files         186      186              
  Lines        6354     6355       +1     
  Branches        3        3              
==========================================
+ Hits         3534     3535       +1     
  Misses       2819     2819              
  Partials        1        1
Impacted Files Coverage Δ
packages/jest-editor-support/src/Settings.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec87e1f...5247dcd. Read the comment docs.

@cpojer cpojer merged commit eff7a1c into jestjs:master Oct 1, 2017
@orta
Copy link
Member

orta commented Oct 1, 2017

<3

tabrindle pushed a commit to tabrindle/jest that referenced this pull request Oct 2, 2017
* --showConfig to show all project configs jestjs#4078

* return configs

* new method getConfigs

* new method getConfigs

* call completed

* eslint

* support jest 20

* lint

* version

* getConfig for jest21

* lint

* fix jest20 bug

* fix bug

* lint

* add type ConfigRepresentations

* remove ConfigRepresentations

* update
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants