Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

make --lastCommit and --changedFilesWithAncestor work without --onlyChanged #5307

Merged
merged 2 commits into from
Jan 15, 2018

Conversation

alsuren
Copy link
Contributor

@alsuren alsuren commented Jan 14, 2018

Summary

This came up in a discussion on another PR of mine, so I decided to fix it: #5189 (comment)

Test plan

~/src/jest$ yarn jest --listTests | wc -l
     220
~/src/jest$ yarn jest --listTests --lastCommit | wc -l
       4
~/src/jest$ yarn jest --listTests --changedFilesWithAncestor | wc -l
       4

before this change, all 3 commands would output 220

@codecov-io
Copy link

codecov-io commented Jan 14, 2018

Codecov Report

Merging #5307 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5307   +/-   ##
=======================================
  Coverage   61.23%   61.23%           
=======================================
  Files         205      205           
  Lines        6891     6891           
  Branches        4        3    -1     
=======================================
  Hits         4220     4220           
  Misses       2670     2670           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afc0a49...31fd272. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the changelog?

@alsuren alsuren force-pushed the implied--onlyChanged branch from fc53821 to 31fd272 Compare January 14, 2018 20:56
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants