-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[jest-leak-detector] remove code repeat #8438
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Simple refactors like this would be fine without a changelog entry for me, but @scotthovestadt seems to like them so I guess it doesn't hurt 😄
Codecov Report
@@ Coverage Diff @@
## master #8438 +/- ##
==========================================
- Coverage 62.33% 62.33% -0.01%
==========================================
Files 266 266
Lines 10737 10736 -1
Branches 2614 2615 +1
==========================================
- Hits 6693 6692 -1
Misses 3461 3461
Partials 583 583
Continue to review full report at Codecov.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
I removed function
isPrimitive
fromjest-leak-detector
because it is already implemented injest-get-type
. DRYTest plan