From 52cdedb40e242c9ed280b821f8493a3872ef2b54 Mon Sep 17 00:00:00 2001 From: Nick Gerleman Date: Tue, 29 Oct 2024 03:43:10 -0700 Subject: [PATCH] Fix missing emitter attributes on iOS TextInput when controlled component value specified using `value` instead of `children` (#47269) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/47269 There were [reports](https://github.com/reactwg/react-native-releases/issues/595) that patching in the fixes for iOS controlled input did not work as expected. I think tracked this down to a difference in how I tested, where the controlled component I used passed value as a child of the `TextInput`, instead of via `value`. Passing via `value` triggers a secondary bug, where we don't correctly pass a reference to correct ShadowView when creating attributedstring, specifically in the iOS TextInputShadowNode impl. We previously passed nothing for the ShadowView (only the first two struct fields). This was exposed in D52589303 which enabled `-Wextra`, but there, I went with same behavior of passing empty ShadowView, instead of the correct behavior (like Android impl) of passing a ShadowView of the current ShadowNode. After fixing this, we now correctly create event emitters in the passed attributedstring, which matches expectations for pargraph-level eventemitter now in typing attributes. We don't seem actually use this on iOS for TextInput right now (just Text), but this is likely the right foundation for events regardless. Changelog: [iOS][Fixed] - Fix missing emitter attributes on iOS TextInput when controlled component value specified using `value` instead of `children` Reviewed By: cipolleschi Differential Revision: D65108163 fbshipit-source-id: 499fe28439fabd2579eca6ded7fd13fd8ea2e43e --- .../renderer/components/iostextinput/TextInputShadowNode.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/react-native/ReactCommon/react/renderer/components/textinput/platform/ios/react/renderer/components/iostextinput/TextInputShadowNode.cpp b/packages/react-native/ReactCommon/react/renderer/components/textinput/platform/ios/react/renderer/components/iostextinput/TextInputShadowNode.cpp index b0a58614ac8725..0bb6d9bacf5599 100644 --- a/packages/react-native/ReactCommon/react/renderer/components/textinput/platform/ios/react/renderer/components/iostextinput/TextInputShadowNode.cpp +++ b/packages/react-native/ReactCommon/react/renderer/components/textinput/platform/ios/react/renderer/components/iostextinput/TextInputShadowNode.cpp @@ -83,7 +83,7 @@ AttributedString TextInputShadowNode::getAttributedString( .string = getConcreteProps().text, .textAttributes = textAttributes, // TODO: Is this really meant to be by value? - .parentShadowView = ShadowView{}}); + .parentShadowView = ShadowView(*this)}); auto attachments = Attachments{}; BaseTextShadowNode::buildAttributedString( @@ -111,7 +111,8 @@ void TextInputShadowNode::updateStateIfNeeded( (!state.layoutManager || state.layoutManager == textLayoutManager_) && "`StateData` refers to a different `TextLayoutManager`"); - if (state.reactTreeAttributedString == reactTreeAttributedString && + if (state.reactTreeAttributedString.isContentEqual( + reactTreeAttributedString) && state.layoutManager == textLayoutManager_) { return; }