From 954f715b25d3c47c35b5a23ae23770a93bc58cee Mon Sep 17 00:00:00 2001 From: Thorben Primke Date: Wed, 24 Apr 2019 06:47:42 -0700 Subject: [PATCH] Adds Logic To Catch MissingWebViewPackageException (#24533) Summary: We are seeing crash reports that the webview is missing. In this case it should fail gracefully so that a missing webview does not block from using an app built with React Native. The contains could also be changed to check for "webview" in general to catch all webview related exception. It's currently checking on for the specific string that I'm seeing in our app's crashreporting tool. Screen Shot 2019-04-19 at 11 26 19 AM Screen Shot 2019-04-19 at 11 32 58 AM [Android] [Fixed] - The ReactCookieJarContainer/ForwardingCookieHandler now handles the missing WebView gracefully. Pull Request resolved: https://github.com/facebook/react-native/pull/24533 Differential Revision: D15062824 Pulled By: cpojer fbshipit-source-id: 80805a47494f0d924b7ee029ce8ca0504eaeee57 --- .../modules/network/ForwardingCookieHandler.java | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/network/ForwardingCookieHandler.java b/ReactAndroid/src/main/java/com/facebook/react/modules/network/ForwardingCookieHandler.java index 2ad5e8fc59989e..23304fe2f2d6d3 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/modules/network/ForwardingCookieHandler.java +++ b/ReactAndroid/src/main/java/com/facebook/react/modules/network/ForwardingCookieHandler.java @@ -182,6 +182,17 @@ protected void doInBackgroundGuarded(Void... params) { } catch (IllegalArgumentException ex) { // https://bugs.chromium.org/p/chromium/issues/detail?id=559720 return null; + } catch (Exception exception) { + String message = exception.getMessage(); + // We cannot catch MissingWebViewPackageException as it is in a private / system API + // class. This validates the exception's message to ensure we are only handling this + // specific exception. + // https://android.googlesource.com/platform/frameworks/base/+/master/core/java/android/webkit/WebViewFactory.java#98 + if (message != null && message.contains("No WebView installed")) { + return null; + } else { + throw exception; + } } if (USES_LEGACY_STORE) {