From fa87eaaebf4103d365adf44d1d14ed6117cb37cb Mon Sep 17 00:00:00 2001 From: Mike Hardy Date: Wed, 27 Sep 2023 14:50:09 -0700 Subject: [PATCH] chore: fix grammar in Xcode 15 helper method name (#39658) Summary: Thanks for working through Xcode 15 compatibility issues! I reviewed the diff of the PR (https://github.com/facebook/react-native/issues/39474) that altered Xcode 15 settings for react-native release 0.72.5 and I noticed that - everything looked great (worth saying) - there was a grammatical error in another of the method names Trivial errors but, as long as I was in there, thought I'd submit a PR ## Changelog: [IOS] [FIXED] - fix grammar in Xcode 15 helper method name Pull Request resolved: https://github.com/facebook/react-native/pull/39658 Test Plan: CI should catch it of course, but in general I did a full grep for the name and changed everything / typical method name refactor Reviewed By: cortinico Differential Revision: D49641551 Pulled By: cipolleschi fbshipit-source-id: d77d33bbd6941f039dd30766e1308d5c4c4a6ca8 --- packages/react-native/scripts/cocoapods/utils.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react-native/scripts/cocoapods/utils.rb b/packages/react-native/scripts/cocoapods/utils.rb index d034f40ac4c38d..7eb2c7bfec77ff 100644 --- a/packages/react-native/scripts/cocoapods/utils.rb +++ b/packages/react-native/scripts/cocoapods/utils.rb @@ -165,7 +165,7 @@ def self.apply_xcode_15_patch(installer, xcodebuild_manager: Xcodebuild) if self.is_using_xcode15_or_greater(:xcodebuild_manager => xcodebuild_manager) self.add_value_to_setting_if_missing(config, other_ld_flags_key, xcode15_compatibility_flags) else - self.remove_value_to_setting_if_present(config, other_ld_flags_key, xcode15_compatibility_flags) + self.remove_value_from_setting_if_present(config, other_ld_flags_key, xcode15_compatibility_flags) end end project.save() @@ -346,7 +346,7 @@ def self.add_value_to_setting_if_missing(config, setting_name, value) end end - def self.remove_value_to_setting_if_present(config, setting_name, value) + def self.remove_value_from_setting_if_present(config, setting_name, value) old_config = config.build_settings[setting_name] if old_config.include?(value) # Old config can be either an Array or a String