Skip to content

Commit 2f685cb

Browse files
committed
[Flight] Support Blobs from Server to Client (#28755)
We currently support Blobs when passing from Client to Server so this adds it in the other direction for parity - when `enableFlightBinary` is enabled. We intentionally only support the `Blob` type to pass-through, not subtype `File`. That's because passing additional meta data like filename might be an accidental leak. You can still pass a `File` through but it'll appear as a `Blob` on the other side. It's also not possible to create a faithful File subclass in all environments without it actually being backed by a file. This implementation isn't great but at least it works. It creates a few indirections. This is because we need to be able to asynchronously emit the buffers but we have to "block" the parent object from resolving while it's loading. Ideally, we should be able to create the Blob on the client early and then stream in it lazily. Because the Blob API doesn't guarantee that the data is available synchronously. Unfortunately, the native APIs doesn't have this. We could implement custom versions of all the data read APIs but then the blobs still wouldn't work with native APIs. So we just have to wait until Blob accepts a stream in the constructor. We should be able to stream each chunk early in the protocol though even though we can't unblock the parent until they've all loaded. I didn't do this yet mostly because of code structure and I'm lazy. DiffTrain build for [c0b5d43](c0b5d43)
1 parent d9f3448 commit 2f685cb

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

compiled/facebook-www/REVISION

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
87b495f7d26a2c631c08952661d38bb5ce5acb03
1+
c0b5d435986e7d9b52a529b73b9317a7e5772172

compiled/facebook-www/ReactFlightDOMClient-dev.modern.js

+6-2
Original file line numberDiff line numberDiff line change
@@ -834,6 +834,10 @@ if (__DEV__) {
834834
return new Set(_data);
835835
}
836836

837+
case "B": {
838+
return undefined;
839+
}
840+
837841
case "I": {
838842
// $Infinity
839843
return Infinity;
@@ -886,9 +890,9 @@ if (__DEV__) {
886890

887891
default: {
888892
// We assume that anything else is a reference ID.
889-
var _id6 = parseInt(value.slice(1), 16);
893+
var _id7 = parseInt(value.slice(1), 16);
890894

891-
var _chunk2 = getChunk(response, _id6);
895+
var _chunk2 = getChunk(response, _id7);
892896

893897
switch (_chunk2.status) {
894898
case RESOLVED_MODEL:

compiled/facebook-www/ReactFlightDOMClient-prod.modern.js

+2
Original file line numberDiff line numberDiff line change
@@ -294,6 +294,8 @@ function parseModelString(response, parentObject, key, value) {
294294
(response = getOutlinedModel(response, parentObject)),
295295
new Set(response)
296296
);
297+
case "B":
298+
return;
297299
case "I":
298300
return Infinity;
299301
case "-":

0 commit comments

Comments
 (0)