Skip to content

Commit 357925a

Browse files
trueadmtrueadm
authored
Move DEV only module requires into __DEV__ blocks (#10185)
* modulesToStub cleaned up and DEV only modules put into __DEV__ blocks * prettier run * Prettier + new build run for bundle sizes
1 parent 9254ce2 commit 357925a

36 files changed

+179
-135
lines changed

‎scripts/rollup/bundles.js

+7-7
Original file line numberDiff line numberDiff line change
@@ -287,10 +287,10 @@ const bundles = [
287287
],
288288
useFiber: false,
289289
modulesToStub: [
290-
"'createReactNativeComponentClassFiber'",
291-
"'ReactNativeFiberRenderer'",
292-
"'findNumericNodeHandleFiber'",
293-
"'ReactNativeFiber'",
290+
'createReactNativeComponentClassFiber',
291+
'ReactNativeFiberRenderer',
292+
'findNumericNodeHandleFiber',
293+
'ReactNativeFiber',
294294
],
295295
},
296296
{
@@ -329,9 +329,9 @@ const bundles = [
329329
],
330330
useFiber: true,
331331
modulesToStub: [
332-
"'createReactNativeComponentClassStack'",
333-
"'findNumericNodeHandleStack'",
334-
"'ReactNativeStack'",
332+
'createReactNativeComponentClassStack',
333+
'findNumericNodeHandleStack',
334+
'ReactNativeStack',
335335
],
336336
},
337337

‎scripts/rollup/modules.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@ function replaceBundleStubModules(bundleModulesToStub) {
274274

275275
if (Array.isArray(bundleModulesToStub)) {
276276
bundleModulesToStub.forEach(module => {
277-
stubbedModules[module] = devOnlyModuleStub;
277+
stubbedModules[`'${module}'`] = devOnlyModuleStub;
278278
});
279279
}
280280

‎scripts/rollup/results.json

+81-81
Original file line numberDiff line numberDiff line change
@@ -1,60 +1,60 @@
11
{
22
"bundleSizes": {
33
"react.development.js (UMD_DEV)": {
4-
"size": 69242,
5-
"gzip": 17754
4+
"size": 69376,
5+
"gzip": 17780
66
},
77
"react.production.min.js (UMD_PROD)": {
88
"size": 7585,
9-
"gzip": 2999
9+
"gzip": 3002
1010
},
1111
"react.development.js (NODE_DEV)": {
12-
"size": 59519,
13-
"gzip": 15370
12+
"size": 59667,
13+
"gzip": 15411
1414
},
1515
"react.production.min.js (NODE_PROD)": {
16-
"size": 6483,
17-
"gzip": 2581
16+
"size": 6451,
17+
"gzip": 2576
1818
},
1919
"React-dev.js (FB_DEV)": {
20-
"size": 56760,
21-
"gzip": 14587
20+
"size": 56905,
21+
"gzip": 14622
2222
},
2323
"React-prod.js (FB_PROD)": {
24-
"size": 26781,
25-
"gzip": 7214
24+
"size": 27099,
25+
"gzip": 7215
2626
},
2727
"react-dom.development.js (UMD_DEV)": {
28-
"size": 625749,
29-
"gzip": 142974
28+
"size": 624799,
29+
"gzip": 142849
3030
},
3131
"react-dom.production.min.js (UMD_PROD)": {
32-
"size": 126740,
33-
"gzip": 40491
32+
"size": 125896,
33+
"gzip": 40026
3434
},
3535
"react-dom.development.js (NODE_DEV)": {
36-
"size": 584404,
37-
"gzip": 133204
36+
"size": 584197,
37+
"gzip": 133211
3838
},
3939
"react-dom.production.min.js (NODE_PROD)": {
40-
"size": 123105,
41-
"gzip": 39158
40+
"size": 122812,
41+
"gzip": 38953
4242
},
4343
"ReactDOMFiber-dev.js (FB_DEV)": {
44-
"size": 583687,
45-
"gzip": 133241
44+
"size": 583480,
45+
"gzip": 133238
4646
},
4747
"ReactDOMFiber-prod.js (FB_PROD)": {
48-
"size": 428780,
49-
"gzip": 97206
48+
"size": 426550,
49+
"gzip": 96621
5050
},
5151
"react-dom-test-utils.development.js (NODE_DEV)": {
52-
"size": 54818,
53-
"gzip": 14071
52+
"size": 54887,
53+
"gzip": 14087
5454
},
5555
"ReactTestUtils-dev.js (FB_DEV)": {
56-
"size": 54697,
57-
"gzip": 14032
56+
"size": 54766,
57+
"gzip": 14049
5858
},
5959
"ReactDOMServerStack-dev.js (FB_DEV)": {
6060
"size": 460810,
@@ -65,20 +65,20 @@
6565
"gzip": 81957
6666
},
6767
"react-dom-server.development.js (UMD_DEV)": {
68-
"size": 119540,
69-
"gzip": 30394
68+
"size": 120136,
69+
"gzip": 30487
7070
},
7171
"react-dom-server.production.min.js (UMD_PROD)": {
72-
"size": 23004,
73-
"gzip": 8753
72+
"size": 20342,
73+
"gzip": 7828
7474
},
7575
"react-dom-server.development.js (NODE_DEV)": {
76-
"size": 88637,
77-
"gzip": 22952
76+
"size": 89286,
77+
"gzip": 23069
7878
},
7979
"react-dom-server.production.min.js (NODE_PROD)": {
80-
"size": 20744,
81-
"gzip": 7879
80+
"size": 18848,
81+
"gzip": 7292
8282
},
8383
"ReactDOMServerStream-dev.js (FB_DEV)": {
8484
"size": 264750,
@@ -89,52 +89,52 @@
8989
"gzip": 51047
9090
},
9191
"react-art.development.js (UMD_DEV)": {
92-
"size": 361251,
93-
"gzip": 80382
92+
"size": 362951,
93+
"gzip": 80594
9494
},
9595
"react-art.production.min.js (UMD_PROD)": {
96-
"size": 98001,
97-
"gzip": 30145
96+
"size": 98449,
97+
"gzip": 30150
9898
},
9999
"react-art.development.js (NODE_DEV)": {
100-
"size": 282663,
101-
"gzip": 60327
100+
"size": 284322,
101+
"gzip": 60517
102102
},
103103
"react-art.production.min.js (NODE_PROD)": {
104-
"size": 59385,
105-
"gzip": 18203
104+
"size": 60011,
105+
"gzip": 18244
106106
},
107107
"ReactARTFiber-dev.js (FB_DEV)": {
108-
"size": 282096,
109-
"gzip": 60239
108+
"size": 283755,
109+
"gzip": 60435
110110
},
111111
"ReactARTFiber-prod.js (FB_PROD)": {
112-
"size": 216336,
113-
"gzip": 45239
112+
"size": 217346,
113+
"gzip": 45283
114114
},
115115
"ReactNativeStack-dev.js (RN_DEV)": {
116-
"size": 186435,
117-
"gzip": 36159
116+
"size": 186585,
117+
"gzip": 36205
118118
},
119119
"ReactNativeStack-prod.js (RN_PROD)": {
120-
"size": 136218,
121-
"gzip": 26177
120+
"size": 136231,
121+
"gzip": 26184
122122
},
123123
"ReactNativeFiber-dev.js (RN_DEV)": {
124-
"size": 282850,
125-
"gzip": 51493
124+
"size": 284554,
125+
"gzip": 51697
126126
},
127127
"ReactNativeFiber-prod.js (RN_PROD)": {
128-
"size": 219044,
129-
"gzip": 38409
128+
"size": 220157,
129+
"gzip": 38484
130130
},
131131
"react-test-renderer.development.js (NODE_DEV)": {
132-
"size": 279806,
133-
"gzip": 59245
132+
"size": 281507,
133+
"gzip": 59442
134134
},
135135
"ReactTestRendererFiber-dev.js (FB_DEV)": {
136-
"size": 279230,
137-
"gzip": 59157
136+
"size": 280931,
137+
"gzip": 59364
138138
},
139139
"react-test-renderer-shallow.development.js (NODE_DEV)": {
140140
"size": 10302,
@@ -145,8 +145,8 @@
145145
"gzip": 2541
146146
},
147147
"react-noop-renderer.development.js (NODE_DEV)": {
148-
"size": 273954,
149-
"gzip": 57671
148+
"size": 275613,
149+
"gzip": 57864
150150
},
151151
"ReactHTMLString-dev.js (FB_DEV)": {
152152
"size": 265654,
@@ -181,20 +181,20 @@
181181
"gzip": 50920
182182
},
183183
"ReactDOMServer-dev.js (FB_DEV)": {
184-
"size": 88149,
185-
"gzip": 22908
184+
"size": 88798,
185+
"gzip": 23020
186186
},
187187
"ReactDOMServer-prod.js (FB_PROD)": {
188-
"size": 53879,
189-
"gzip": 14872
188+
"size": 49545,
189+
"gzip": 13626
190190
},
191191
"react-dom-node-stream.development.js (NODE_DEV)": {
192-
"size": 90331,
193-
"gzip": 23443
192+
"size": 90980,
193+
"gzip": 23577
194194
},
195195
"react-dom-node-stream.production.min.js (NODE_PROD)": {
196-
"size": 21682,
197-
"gzip": 8219
196+
"size": 19785,
197+
"gzip": 7628
198198
},
199199
"ReactDOMNodeStream-dev.js (FB_DEV)": {
200200
"size": 264918,
@@ -205,28 +205,28 @@
205205
"gzip": 50956
206206
},
207207
"react-dom-unstable-native-dependencies.development.js (UMD_DEV)": {
208-
"size": 83909,
209-
"gzip": 21018
208+
"size": 84047,
209+
"gzip": 21057
210210
},
211211
"react-dom-unstable-native-dependencies.production.min.js (UMD_PROD)": {
212-
"size": 18318,
213-
"gzip": 5971
212+
"size": 18315,
213+
"gzip": 5967
214214
},
215215
"react-dom-unstable-native-dependencies.development.js (NODE_DEV)": {
216-
"size": 77322,
217-
"gzip": 19063
216+
"size": 77475,
217+
"gzip": 19101
218218
},
219219
"react-dom-unstable-native-dependencies.production.min.js (NODE_PROD)": {
220-
"size": 16620,
221-
"gzip": 5340
220+
"size": 16588,
221+
"gzip": 5332
222222
},
223223
"ReactDOMUnstableNativeDependencies-dev.js (FB_DEV)": {
224-
"size": 77036,
225-
"gzip": 19026
224+
"size": 77189,
225+
"gzip": 19061
226226
},
227227
"ReactDOMUnstableNativeDependencies-prod.js (FB_PROD)": {
228-
"size": 65934,
229-
"gzip": 15705
228+
"size": 65908,
229+
"gzip": 15704
230230
}
231231
}
232232
}

‎src/isomorphic/children/flattenChildren.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,12 @@
1313
'use strict';
1414

1515
var traverseAllChildren = require('traverseAllChildren');
16-
var warning = require('fbjs/lib/warning');
1716
var ReactComponentTreeHook = require('ReactComponentTreeHook');
1817

18+
if (__DEV__) {
19+
var warning = require('fbjs/lib/warning');
20+
}
21+
1922
/**
2023
* @param {function} traverseContext Context passed through traversal.
2124
* @param {?ReactComponent} child React child component.

‎src/isomorphic/children/traverseAllChildren.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313

1414
var emptyFunction = require('fbjs/lib/emptyFunction');
1515
var invariant = require('fbjs/lib/invariant');
16-
var warning = require('fbjs/lib/warning');
1716

1817
var ITERATOR_SYMBOL = typeof Symbol === 'function' && Symbol.iterator;
1918
var FAUX_ITERATOR_SYMBOL = '@@iterator'; // Before Symbol spec.
@@ -24,6 +23,7 @@ var REACT_ELEMENT_TYPE =
2423
0xeac7;
2524

2625
if (__DEV__) {
26+
var warning = require('fbjs/lib/warning');
2727
var {getStackAddendum} = require('ReactDebugCurrentFrame');
2828
}
2929

‎src/isomorphic/classic/element/ReactElement.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,12 @@
1212
'use strict';
1313

1414
var ReactCurrentOwner = require('ReactCurrentOwner');
15-
16-
var warning = require('fbjs/lib/warning');
1715
var hasOwnProperty = Object.prototype.hasOwnProperty;
1816

17+
if (__DEV__) {
18+
var warning = require('fbjs/lib/warning');
19+
}
20+
1921
// The Symbol used to tag the ReactElement type. If there is no native Symbol
2022
// nor polyfill, then a plain number is used for performance.
2123
var REACT_ELEMENT_TYPE =

‎src/isomorphic/hooks/ReactComponentTreeHook.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,12 @@
1414

1515
var ReactCurrentOwner = require('ReactCurrentOwner');
1616
var invariant = require('fbjs/lib/invariant');
17-
var warning = require('fbjs/lib/warning');
1817
var describeComponentFrame = require('describeComponentFrame');
1918

19+
if (__DEV__) {
20+
var warning = require('fbjs/lib/warning');
21+
}
22+
2023
import type {ReactElement, Source} from 'ReactElementType';
2124
import type {DebugID} from 'ReactInstanceType';
2225

‎src/isomorphic/modern/class/ReactNoopUpdateQueue.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@
1111

1212
'use strict';
1313

14-
var warning = require('fbjs/lib/warning');
14+
if (__DEV__) {
15+
var warning = require('fbjs/lib/warning');
16+
}
1517

1618
function warnNoop(publicInstance, callerName) {
1719
if (__DEV__) {

‎src/renderers/dom/ReactDOMStackEntry.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,10 @@ var ReactVersion = require('ReactVersion');
2222

2323
var findDOMNode = require('findDOMNode');
2424
var getHostComponentFromComposite = require('getHostComponentFromComposite');
25-
var warning = require('fbjs/lib/warning');
25+
26+
if (__DEV__) {
27+
var warning = require('fbjs/lib/warning');
28+
}
2629

2730
require('ReactDOMInjection');
2831
require('ReactDOMClientInjection');

0 commit comments

Comments
 (0)