Skip to content

Commit 7f3c69b

Browse files
author
Keyan Zhang
committed
LinkedValueUtils should only export checkPropTypes in dev
- all the usage of `LinkedValueUtils.checkPropTypes` are under `__DEV__` - if we can use named exports this won't be an issue anymore
1 parent b0a4be4 commit 7f3c69b

File tree

1 file changed

+23
-21
lines changed

1 file changed

+23
-21
lines changed

src/renderers/dom/client/wrappers/LinkedValueUtils.js

Lines changed: 23 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -102,27 +102,6 @@ function getDeclarationErrorAddendum(owner) {
102102
* this outside of the ReactDOM controlled form components.
103103
*/
104104
var LinkedValueUtils = {
105-
checkPropTypes: function(tagName, props, owner) {
106-
for (var propName in propTypes) {
107-
if (propTypes.hasOwnProperty(propName)) {
108-
var error = propTypes[propName](
109-
props,
110-
propName,
111-
tagName,
112-
ReactPropTypeLocations.prop
113-
);
114-
}
115-
if (error instanceof Error && !(error.message in loggedTypeFailures)) {
116-
// Only monitor this failure once because there tends to be a lot of the
117-
// same error.
118-
loggedTypeFailures[error.message] = true;
119-
120-
var addendum = getDeclarationErrorAddendum(owner);
121-
warning(false, 'Failed form propType: %s%s', error.message, addendum);
122-
}
123-
}
124-
},
125-
126105
/**
127106
* @param {object} inputProps Props for form component
128107
* @return {*} current value of the input either from value prop or link.
@@ -165,4 +144,27 @@ var LinkedValueUtils = {
165144
},
166145
};
167146

147+
if (__DEV__) {
148+
LinkedValueUtils.checkPropTypes = function(tagName, props, owner) {
149+
for (var propName in propTypes) {
150+
if (propTypes.hasOwnProperty(propName)) {
151+
var error = propTypes[propName](
152+
props,
153+
propName,
154+
tagName,
155+
ReactPropTypeLocations.prop
156+
);
157+
}
158+
if (error instanceof Error && !(error.message in loggedTypeFailures)) {
159+
// Only monitor this failure once because there tends to be a lot of the
160+
// same error.
161+
loggedTypeFailures[error.message] = true;
162+
163+
var addendum = getDeclarationErrorAddendum(owner);
164+
warning(false, 'Failed form propType: %s%s', error.message, addendum);
165+
}
166+
}
167+
};
168+
}
169+
168170
module.exports = LinkedValueUtils;

0 commit comments

Comments
 (0)