Skip to content

Commit 870e404

Browse files
authored
[tests] add assertLog for legacy mode tests (#28814)
A few more tests for #28737
1 parent a8a83f7 commit 870e404

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

packages/react-dom/src/__tests__/ReactDOMSuspensePlaceholder-test.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ describe('ReactDOMSuspensePlaceholder', () => {
132132
expect(window.getComputedStyle(divs[0].current).display).toEqual('none');
133133
expect(window.getComputedStyle(divs[1].current).display).toEqual('none');
134134
expect(window.getComputedStyle(divs[2].current).display).toEqual('none');
135-
135+
assertLog(['A', 'Suspend! [B]', 'C', 'Loading...']);
136136
await act(async () => {
137137
await resolveText('B');
138138
});
@@ -141,6 +141,7 @@ describe('ReactDOMSuspensePlaceholder', () => {
141141
expect(window.getComputedStyle(divs[1].current).display).toEqual('block');
142142
// This div's display was set with a prop.
143143
expect(window.getComputedStyle(divs[2].current).display).toEqual('inline');
144+
assertLog(['B']);
144145
});
145146

146147
it('hides and unhides timed out text nodes', async () => {
@@ -203,6 +204,7 @@ describe('ReactDOMSuspensePlaceholder', () => {
203204
'<span style="display: none;">Sibling</span><span style=' +
204205
'"display: none;"></span>Loading...',
205206
);
207+
assertLog(['Suspend! [Async]', 'Loading...']);
206208

207209
// Update the inline display style. It will be overridden because it's
208210
// inside a hidden fallback.
@@ -211,6 +213,7 @@ describe('ReactDOMSuspensePlaceholder', () => {
211213
'<span style="display: none;">Sibling</span><span style=' +
212214
'"display: none;"></span>Loading...',
213215
);
216+
assertLog(['Suspend! [Async]']);
214217

215218
// Unsuspend. The style should now match the inline prop.
216219
await act(() => resolveText('Async'));

packages/react-dom/src/__tests__/ReactLegacyUpdates-test.js

+1
Original file line numberDiff line numberDiff line change
@@ -1668,6 +1668,7 @@ describe('ReactLegacyUpdates', () => {
16681668
await act(() => {
16691669
ReactDOM.render(<Terminating />, container);
16701670
});
1671+
assertLog(Array.from({length: LIMIT + 1}, (_, k) => k));
16711672
expect(container.textContent).toBe('50');
16721673
await act(() => {
16731674
_setStep(0);

0 commit comments

Comments
 (0)