Skip to content

Commit b273ac4

Browse files
eps1loneps1lon
committed
Dim console calls on additional Effect invocations due to StrictMode (#29007)
DiffTrain build for [3ac551e](3ac551e)
1 parent ca580d7 commit b273ac4

9 files changed

+33
-9
lines changed

Diff for: ‎compiled/facebook-www/REVISION

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
217b2ccf160d7594a926d276a75c7312b299be4d
1+
3ac551e855f9bec3161da2fc8787958aa62113db

Diff for: ‎compiled/facebook-www/ReactART-dev.classic.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ function _assertThisInitialized(self) {
6060
return self;
6161
}
6262

63-
var ReactVersion = '19.0.0-www-classic-27733b1d';
63+
var ReactVersion = '19.0.0-www-classic-52a43e30';
6464

6565
var LegacyRoot = 0;
6666
var ConcurrentRoot = 1;
@@ -24687,6 +24687,7 @@ function recursivelyTraverseAndDoubleInvokeEffectsInDEV(root, parentFiber, isInS
2468724687

2468824688
function doubleInvokeEffectsOnFiber(root, fiber) {
2468924689
var shouldDoubleInvokePassiveEffects = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : true;
24690+
setIsStrictModeForDevtools(true);
2469024691
disappearLayoutEffects(fiber);
2469124692

2469224693
if (shouldDoubleInvokePassiveEffects) {
@@ -24698,6 +24699,8 @@ function doubleInvokeEffectsOnFiber(root, fiber) {
2469824699
if (shouldDoubleInvokePassiveEffects) {
2469924700
reconnectPassiveEffects(root, fiber, NoLanes, null, false);
2470024701
}
24702+
24703+
setIsStrictModeForDevtools(false);
2470124704
}
2470224705

2470324706
function doubleInvokeEffectsInDEVIfNecessary(root, fiber, parentIsInStrictMode) {

Diff for: ‎compiled/facebook-www/ReactART-dev.modern.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ function _assertThisInitialized(self) {
6060
return self;
6161
}
6262

63-
var ReactVersion = '19.0.0-www-modern-bddd4eac';
63+
var ReactVersion = '19.0.0-www-modern-c5403897';
6464

6565
var LegacyRoot = 0;
6666
var ConcurrentRoot = 1;
@@ -24041,6 +24041,7 @@ function recursivelyTraverseAndDoubleInvokeEffectsInDEV(root, parentFiber, isInS
2404124041

2404224042
function doubleInvokeEffectsOnFiber(root, fiber) {
2404324043
var shouldDoubleInvokePassiveEffects = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : true;
24044+
setIsStrictModeForDevtools(true);
2404424045
disappearLayoutEffects(fiber);
2404524046

2404624047
if (shouldDoubleInvokePassiveEffects) {
@@ -24052,6 +24053,8 @@ function doubleInvokeEffectsOnFiber(root, fiber) {
2405224053
if (shouldDoubleInvokePassiveEffects) {
2405324054
reconnectPassiveEffects(root, fiber, NoLanes, null, false);
2405424055
}
24056+
24057+
setIsStrictModeForDevtools(false);
2405524058
}
2405624059

2405724060
function doubleInvokeEffectsInDEVIfNecessary(root, fiber, parentIsInStrictMode) {

Diff for: ‎compiled/facebook-www/ReactDOM-dev.classic.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -29418,6 +29418,7 @@ function recursivelyTraverseAndDoubleInvokeEffectsInDEV(root, parentFiber, isInS
2941829418

2941929419
function doubleInvokeEffectsOnFiber(root, fiber) {
2942029420
var shouldDoubleInvokePassiveEffects = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : true;
29421+
setIsStrictModeForDevtools(true);
2942129422
disappearLayoutEffects(fiber);
2942229423

2942329424
if (shouldDoubleInvokePassiveEffects) {
@@ -29429,6 +29430,8 @@ function doubleInvokeEffectsOnFiber(root, fiber) {
2942929430
if (shouldDoubleInvokePassiveEffects) {
2943029431
reconnectPassiveEffects(root, fiber, NoLanes, null, false);
2943129432
}
29433+
29434+
setIsStrictModeForDevtools(false);
2943229435
}
2943329436

2943429437
function doubleInvokeEffectsInDEVIfNecessary(root, fiber, parentIsInStrictMode) {
@@ -30852,7 +30855,7 @@ identifierPrefix, onUncaughtError, onCaughtError, onRecoverableError, transition
3085230855
return root;
3085330856
}
3085430857

30855-
var ReactVersion = '19.0.0-www-classic-568ec550';
30858+
var ReactVersion = '19.0.0-www-classic-48001749';
3085630859

3085730860
function createPortal$1(children, containerInfo, // TODO: figure out the API for cross-renderer implementation.
3085830861
implementation) {

Diff for: ‎compiled/facebook-www/ReactDOM-dev.modern.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -28669,6 +28669,7 @@ function recursivelyTraverseAndDoubleInvokeEffectsInDEV(root, parentFiber, isInS
2866928669

2867028670
function doubleInvokeEffectsOnFiber(root, fiber) {
2867128671
var shouldDoubleInvokePassiveEffects = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : true;
28672+
setIsStrictModeForDevtools(true);
2867228673
disappearLayoutEffects(fiber);
2867328674

2867428675
if (shouldDoubleInvokePassiveEffects) {
@@ -28680,6 +28681,8 @@ function doubleInvokeEffectsOnFiber(root, fiber) {
2868028681
if (shouldDoubleInvokePassiveEffects) {
2868128682
reconnectPassiveEffects(root, fiber, NoLanes, null, false);
2868228683
}
28684+
28685+
setIsStrictModeForDevtools(false);
2868328686
}
2868428687

2868528688
function doubleInvokeEffectsInDEVIfNecessary(root, fiber, parentIsInStrictMode) {
@@ -30027,7 +30030,7 @@ identifierPrefix, onUncaughtError, onCaughtError, onRecoverableError, transition
3002730030
return root;
3002830031
}
3002930032

30030-
var ReactVersion = '19.0.0-www-modern-1d14d92b';
30033+
var ReactVersion = '19.0.0-www-modern-899aca39';
3003130034

3003230035
function createPortal$1(children, containerInfo, // TODO: figure out the API for cross-renderer implementation.
3003330036
implementation) {

Diff for: ‎compiled/facebook-www/ReactDOMTesting-dev.classic.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -29984,6 +29984,7 @@ function recursivelyTraverseAndDoubleInvokeEffectsInDEV(root, parentFiber, isInS
2998429984

2998529985
function doubleInvokeEffectsOnFiber(root, fiber) {
2998629986
var shouldDoubleInvokePassiveEffects = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : true;
29987+
setIsStrictModeForDevtools(true);
2998729988
disappearLayoutEffects(fiber);
2998829989

2998929990
if (shouldDoubleInvokePassiveEffects) {
@@ -29995,6 +29996,8 @@ function doubleInvokeEffectsOnFiber(root, fiber) {
2999529996
if (shouldDoubleInvokePassiveEffects) {
2999629997
reconnectPassiveEffects(root, fiber, NoLanes, null, false);
2999729998
}
29999+
30000+
setIsStrictModeForDevtools(false);
2999830001
}
2999930002

3000030003
function doubleInvokeEffectsInDEVIfNecessary(root, fiber, parentIsInStrictMode) {
@@ -31418,7 +31421,7 @@ identifierPrefix, onUncaughtError, onCaughtError, onRecoverableError, transition
3141831421
return root;
3141931422
}
3142031423

31421-
var ReactVersion = '19.0.0-www-classic-96e3c07d';
31424+
var ReactVersion = '19.0.0-www-classic-5c88d62e';
3142231425

3142331426
function createPortal$1(children, containerInfo, // TODO: figure out the API for cross-renderer implementation.
3142431427
implementation) {

Diff for: ‎compiled/facebook-www/ReactDOMTesting-dev.modern.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -29235,6 +29235,7 @@ function recursivelyTraverseAndDoubleInvokeEffectsInDEV(root, parentFiber, isInS
2923529235

2923629236
function doubleInvokeEffectsOnFiber(root, fiber) {
2923729237
var shouldDoubleInvokePassiveEffects = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : true;
29238+
setIsStrictModeForDevtools(true);
2923829239
disappearLayoutEffects(fiber);
2923929240

2924029241
if (shouldDoubleInvokePassiveEffects) {
@@ -29246,6 +29247,8 @@ function doubleInvokeEffectsOnFiber(root, fiber) {
2924629247
if (shouldDoubleInvokePassiveEffects) {
2924729248
reconnectPassiveEffects(root, fiber, NoLanes, null, false);
2924829249
}
29250+
29251+
setIsStrictModeForDevtools(false);
2924929252
}
2925029253

2925129254
function doubleInvokeEffectsInDEVIfNecessary(root, fiber, parentIsInStrictMode) {
@@ -30593,7 +30596,7 @@ identifierPrefix, onUncaughtError, onCaughtError, onRecoverableError, transition
3059330596
return root;
3059430597
}
3059530598

30596-
var ReactVersion = '19.0.0-www-modern-8378a978';
30599+
var ReactVersion = '19.0.0-www-modern-8a4086e1';
3059730600

3059830601
function createPortal$1(children, containerInfo, // TODO: figure out the API for cross-renderer implementation.
3059930602
implementation) {

Diff for: ‎compiled/facebook-www/ReactReconciler-dev.classic.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -27208,6 +27208,7 @@ function recursivelyTraverseAndDoubleInvokeEffectsInDEV(root, parentFiber, isInS
2720827208

2720927209
function doubleInvokeEffectsOnFiber(root, fiber) {
2721027210
var shouldDoubleInvokePassiveEffects = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : true;
27211+
setIsStrictModeForDevtools(true);
2721127212
disappearLayoutEffects(fiber);
2721227213

2721327214
if (shouldDoubleInvokePassiveEffects) {
@@ -27219,6 +27220,8 @@ function doubleInvokeEffectsOnFiber(root, fiber) {
2721927220
if (shouldDoubleInvokePassiveEffects) {
2722027221
reconnectPassiveEffects(root, fiber, NoLanes, null, false);
2722127222
}
27223+
27224+
setIsStrictModeForDevtools(false);
2722227225
}
2722327226

2722427227
function doubleInvokeEffectsInDEVIfNecessary(root, fiber, parentIsInStrictMode) {
@@ -28650,7 +28653,7 @@ identifierPrefix, onUncaughtError, onCaughtError, onRecoverableError, transition
2865028653
return root;
2865128654
}
2865228655

28653-
var ReactVersion = '19.0.0-www-classic-d0612afb';
28656+
var ReactVersion = '19.0.0-www-classic-e2e5cb48';
2865428657

2865528658
/*
2865628659
* The `'' + value` pattern (used in perf-sensitive code) throws for Symbol

Diff for: ‎compiled/facebook-www/ReactReconciler-dev.modern.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -26550,6 +26550,7 @@ function recursivelyTraverseAndDoubleInvokeEffectsInDEV(root, parentFiber, isInS
2655026550

2655126551
function doubleInvokeEffectsOnFiber(root, fiber) {
2655226552
var shouldDoubleInvokePassiveEffects = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : true;
26553+
setIsStrictModeForDevtools(true);
2655326554
disappearLayoutEffects(fiber);
2655426555

2655526556
if (shouldDoubleInvokePassiveEffects) {
@@ -26561,6 +26562,8 @@ function doubleInvokeEffectsOnFiber(root, fiber) {
2656126562
if (shouldDoubleInvokePassiveEffects) {
2656226563
reconnectPassiveEffects(root, fiber, NoLanes, null, false);
2656326564
}
26565+
26566+
setIsStrictModeForDevtools(false);
2656426567
}
2656526568

2656626569
function doubleInvokeEffectsInDEVIfNecessary(root, fiber, parentIsInStrictMode) {
@@ -27916,7 +27919,7 @@ identifierPrefix, onUncaughtError, onCaughtError, onRecoverableError, transition
2791627919
return root;
2791727920
}
2791827921

27919-
var ReactVersion = '19.0.0-www-modern-80961c3b';
27922+
var ReactVersion = '19.0.0-www-modern-a0174ad9';
2792027923

2792127924
/*
2792227925
* The `'' + value` pattern (used in perf-sensitive code) throws for Symbol

0 commit comments

Comments
 (0)