Updated the utfDecodeString() method to avoid call stack exceeded error

Brian Vaughn · Brian Vaughn · commit bb7be5554d33 · 2021-09-15T18:13:25.000-04:00
diff --git a/packages/react-devtools-shared/src/utils.js b/packages/react-devtools-shared/src/utils.js
@@ -126,7 +126,11 @@ export function getUID(): number {
 }
 
 export function utfDecodeString(array: Array<number>): string {
-  return String.fromCodePoint(...array);
+  // Note that we intentionally map over the Array,
+  // rather than spreading it (String.fromCodePoint(...array))
+  // to avoid exceeding the stack call size in the Babel-generated code.
+  // See github.com/facebook/react/issues/22293#issuecomment-919551764
+  return array.map(char => String.fromCodePoint(char)).join('');
 }
 
 export function utfEncodeString(string: string): Array<number> {

Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,11 @@ export function getUID(): number {`
`126`	`126`	`}`
`127`	`127`
`128`	`128`	`export function utfDecodeString(array: Array<number>): string {`
`129`		`- return String.fromCodePoint(...array);`
	`129`	`+ // Note that we intentionally map over the Array,`
	`130`	`+ // rather than spreading it (String.fromCodePoint(...array))`
	`131`	`+ // to avoid exceeding the stack call size in the Babel-generated code.`
	`132`	`+ // See github.com/facebook/react/issues/22293#issuecomment-919551764`
	`133`	`+ return array.map(char => String.fromCodePoint(char)).join('');`
`130`	`134`	`}`
`131`	`135`
`132`	`136`	`export function utfEncodeString(string: string): Array<number> {`